Make the minimize state work when creating a chrome window in CrOS

ui/views/widget/native_widget_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/native_widget_aura.h"
 
 #include "base/bind.h"
 #include "base/strings/string_util.h"
 #include "third_party/skia/include/core/SkRegion.h"
 #include "ui/aura/client/aura_constants.h"
@@ skipping 466 matching lines @@
 void NativeWidgetAura::ShowMaximizedWithBounds(
     const gfx::Rect& restored_bounds) {
   SetRestoreBounds(window_, restored_bounds);
   ShowWithWindowState(ui::SHOW_STATE_MAXIMIZED);
 }
 
 void NativeWidgetAura::ShowWithWindowState(ui::WindowShowState state) {
   if (!window_)
     return;
 
-  if (state == ui::SHOW_STATE_MAXIMIZED || state == ui::SHOW_STATE_FULLSCREEN)
-    window_->SetProperty(aura::client::kShowStateKey, state);
+  window_->SetProperty(aura::client::kShowStateKey, state);
+  if (state == ui::SHOW_STATE_MINIMIZED)
+    return;
+

[sadrul, 2015/05/18 19:51:42]

Why? This looks like a change in behaviour.

[joone, 2015/05/18 20:22:43]

The minimized state doesn't work when we running the blow code.

[sadrul, 2015/05/18 20:29:27]

Why? We currently do run the code below for MINIMIZED, right? Why can't we do
that if we set the property?

[oshima, 2015/05/18 20:48:06]

Showing (or activating) minimized window will unminimize the window, and that's
probably why. That's being said, allowing MINIMINIZED here may sounds a
contradiction because a minimized window isn't shown. Maybe caller should just
call minimized?

   window_->Show();
   if (delegate_->CanActivate()) {
     if (state != ui::SHOW_STATE_INACTIVE)
       Activate();
     // SetInitialFocus() should be always be called, even for
     // SHOW_STATE_INACTIVE. If the window has to stay inactive, the method will
     // do the right thing.
     SetInitialFocus(state);
   }
 }
@@ skipping 706 matching lines @@
   l10n_util::AdjustUIFont(&(ncm.lfCaptionFont));
   base::win::ScopedHFONT caption_font(CreateFontIndirect(&(ncm.lfCaptionFont)));
   return gfx::FontList(gfx::Font(caption_font));
 #else
   return gfx::FontList();
 #endif
 }
 
 }  // namespace internal
 }  // namespace views