Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1130013003: Replace moveTo and resizeTo with outerBounds= (Closed)

Created:
5 years, 7 months ago by Jamie
Modified:
5 years, 7 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace moveTo and resizeTo with outerBounds= The moveTo and resizeTo methods are deprecated; setting outerBounds is the recommended replacement. BUG=485707 Committed: https://crrev.com/edd02b862ed57a7d8fcf3f98417ce46a4848608d Cr-Commit-Position: refs/heads/master@{#329215}

Patch Set 1 #

Patch Set 2 : Simplified. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -25 lines) Patch
M remoting/webapp/base/js/base.js View 1 1 chunk +8 lines, -13 lines 0 comments Download
M remoting/webapp/browser_test/scrollbar_browser_test.js View 1 1 chunk +2 lines, -1 line 1 comment Download
M remoting/webapp/js_proto/chrome_proto.js View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jamie
5 years, 7 months ago (2015-05-08 20:37:51 UTC) #3
kelvinp
lgtm https://codereview.chromium.org/1130013003/diff/40001/remoting/webapp/browser_test/scrollbar_browser_test.js File remoting/webapp/browser_test/scrollbar_browser_test.js (left): https://codereview.chromium.org/1130013003/diff/40001/remoting/webapp/browser_test/scrollbar_browser_test.js#oldcode17 remoting/webapp/browser_test/scrollbar_browser_test.js:17: 'use strict'; Looks like this test is currently ...
5 years, 7 months ago (2015-05-11 17:20:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130013003/40001
5 years, 7 months ago (2015-05-11 18:11:42 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 7 months ago (2015-05-11 19:07:18 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 19:08:14 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/edd02b862ed57a7d8fcf3f98417ce46a4848608d
Cr-Commit-Position: refs/heads/master@{#329215}

Powered by Google App Engine
This is Rietveld 408576698