Adding BLE connection finder unit tests.

components/proximity_auth/ble/bluetooth_low_energy_connection_finder.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PROXIMITY_AUTH_BLE_BLUETOOTH_LOW_ENERGY_CONNECTION_FINDER_H
 #define COMPONENTS_PROXIMITY_AUTH_BLE_BLUETOOTH_LOW_ENERGY_CONNECTION_FINDER_H
 
 #include <set>
 #include <string>
 
@@ skipping 30 matching lines @@
 
   // Closes the connection and forgets the device.
   void CloseGattConnection(
       scoped_ptr<device::BluetoothGattConnection> gatt_connection);
 
   // proximity_auth::ConnectionObserver:
   void OnConnectionStatusChanged(Connection* connection,
                                  Connection::Status old_status,
                                  Connection::Status new_status) override;
 
- protected:
   // device::BluetoothAdapter::Observer:
   void DeviceAdded(device::BluetoothAdapter* adapter,
                    device::BluetoothDevice* device) override;
   void DeviceChanged(device::BluetoothAdapter* adapter,
                      device::BluetoothDevice* device) override;
   void DeviceRemoved(device::BluetoothAdapter* adapter,
                      device::BluetoothDevice* device) override;
 
+ protected:
+  // Creates a connection with |remote_device|. Exposed for testing.

[Tim Song, 2015/05/20 07:47:00]

nit: this comment isn't up to date anymore.

[sacomoto, 2015/05/20 22:34:21]

Done.

+  virtual scoped_ptr<Connection> CreateConnection(
+      scoped_ptr<device::BluetoothGattConnection> gatt_connection);
+
  private:
   // Callback to be called when the Bluetooth adapter is initialized.
   void OnAdapterInitialized(scoped_refptr<device::BluetoothAdapter> adapter);
 
   // Checks if |remote_device| contains |remote_service_uuid| and creates a
   // connection in that case.
   void HandleDeviceUpdated(device::BluetoothDevice* remote_device);
 
   // Callback called when a new discovery session is started.
   void OnDiscoverySessionStarted(
@@ skipping 23 matching lines @@
       device::BluetoothDevice::ConnectErrorCode error_code);
 
   // Callback called when a GATT connection is created.
   void OnGattConnectionCreated(
       scoped_ptr<device::BluetoothGattConnection> gatt_connection);
 
   // Creates a GATT connection with |remote_device|, |connection_callback_| will
   // be called once the connection is established.
   void CreateGattConnection(device::BluetoothDevice* remote_device);
 
-  // Creates a connection with |remote_device|.
-  scoped_ptr<Connection> CreateConnection(
-      scoped_ptr<device::BluetoothGattConnection> gatt_connection);
-
   // The uuid of the service it looks for to establish a GattConnection.
   device::BluetoothUUID remote_service_uuid_;
 
   // Characteristic used to send data to the remote device.
   device::BluetoothUUID to_peripheral_char_uuid_;
 
   // Characteristic used to receive data from the remote device.
   device::BluetoothUUID from_peripheral_char_uuid_;
 
   // The Bluetooth adapter over which the Bluetooth connection will be made.
@@ skipping 17 matching lines @@
   std::set<device::BluetoothDevice*> pending_connections_;
 
   base::WeakPtrFactory<BluetoothLowEnergyConnectionFinder> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(BluetoothLowEnergyConnectionFinder);
 };
 
 }  // namespace proximity_auth
 
 #endif  // COMPONENTS_PROXIMITY_AUTH_BLE_BLUETOOTH_CONNECTION_FINDER_H