Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1129983003: Handle HTTP-Version information as per RFC2616 sec 3.1 references.

Created:
5 years, 7 months ago by payal.pandey
Modified:
5 years, 7 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle HTTP-Version information as per RFC2616 sec 3.1 references. As per RFC2616 sec 3.1: HTTP-Version = "HTTP" "/" 1*DIGIT "." 1*DIGIT Previously 1*DIGIT only handle 1 digit, And now logic implemented for one or more digits as specified in TODO comments. BUG=382120

Patch Set 1 #

Patch Set 2 : Replace stoi use to base::StringToInt #

Patch Set 3 : Added Unittest and incorparated review comments #

Patch Set 4 : Incorporated review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -6 lines) Patch
M net/http/http_response_headers.cc View 1 2 3 2 chunks +32 lines, -6 lines 0 comments Download
M net/http/http_response_headers_unittest.cc View 1 2 3 1 chunk +117 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
payal.pandey
Please have a look, Thanks.
5 years, 7 months ago (2015-05-07 10:47:45 UTC) #2
payal.pandey
.
5 years, 7 months ago (2015-05-07 11:17:21 UTC) #3
eroman
not lgtm: * Needs test cases * Should test for error conditions. For instance StringToInt() ...
5 years, 7 months ago (2015-05-08 02:54:56 UTC) #4
payal.pandey
Please have a look, again. Thanks
5 years, 7 months ago (2015-05-20 13:45:57 UTC) #5
eroman
I didn't review in depth, but it looks better. A few quick comments: * The ...
5 years, 7 months ago (2015-05-20 22:16:16 UTC) #6
payal.pandey
Updated as per review comments except leading zeros. As this CL is only targeting 1*More ...
5 years, 7 months ago (2015-05-21 07:41:02 UTC) #7
payal.pandey
5 years, 7 months ago (2015-05-23 19:26:22 UTC) #8
Please review the updated CL

Powered by Google App Engine
This is Rietveld 408576698