Avoid duplicated painting of replaced object outline

Avoid duplicated painting of replaced object outline

BUG=485644
TEST=virtual/slimmingpaint/media/video-controls-dont-show-on-focus-when-disabled.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195140

[Xianzhu, 2015-05-08 18:22:44]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org, trchen@chromium.org

[Xianzhu, 2015-05-08 18:25:23]

Please review Patch Set 3.

[Xianzhu, 2015-05-09 00:08:19]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-09 00:09:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1129973003/60001

[chrishtr, 2015-05-09 00:42:17]

lgtm

I can see why it was doing extra painting before, but was it actually painting
the outline twice or was it painting outline+more stuff during
PaintPhaseOutline?

[Xianzhu, 2015-05-09 05:11:05]

The CQ bit was unchecked by wangxianzhu@chromium.org

[Xianzhu, 2015-05-09 05:11:12]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2015-05-09 05:11:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1129973003/60001

[Xianzhu, 2015-05-09 05:13:58]

On 2015/05/09 00:42:17, chrishtr wrote:
> lgtm
> 
> I can see why it was doing extra painting before, but was it actually painting
> the outline twice or was it painting outline+more stuff during
> PaintPhaseOutline?

Actually yes, but they are wrong:
- VideoPainter will paint the poster image and video frame in PaintPhaseOutline,
and will paint them again in PaintPhaseForeground;
- SVGRootPainter will pass the same paintInfo to all children.

[commit-bot: I haz the power, 2015-05-09 06:25:40]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195140