chrome/browser/metrics/thread_watcher_android_unittest.cc - Issue 1129953004: Reland: Lazily initialize MessageLoop for faster thread startup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/thread_watcher_android_unittest.cc

Issue 1129953004: Reland: Lazily initialize MessageLoop for faster thread startup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Windows race fix (crbug.com/485157) and ThreadWatcherAndroid fix (crbug.com/485091) Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/metrics/thread_watcher_android_unittest.cc

diff --git a/chrome/browser/metrics/thread_watcher_android_unittest.cc b/chrome/browser/metrics/thread_watcher_android_unittest.cc

index 62489b671d2a5de823033ea0f2f564c513a019b3..2b5c04f6bf4d7ce834c10c060b17f9d3e416c361 100644

--- a/chrome/browser/metrics/thread_watcher_android_unittest.cc

+++ b/chrome/browser/metrics/thread_watcher_android_unittest.cc

@@ -48,7 +48,7 @@ TEST(ThreadWatcherAndroidTest, DISABLED_ApplicationStatusNotification) {

scoped_ptr<WatchDogThread> watchdog_thread_(new WatchDogThread());

- watchdog_thread_->Start();

+ watchdog_thread_->StartAndWaitForTesting();

EXPECT_FALSE(ThreadWatcherList::g_thread_watcher_list_);

« base/threading/thread.cc ('K') | « chrome/browser/io_thread.cc ('k') | chrome/browser/metrics/thread_watcher_unittest.cc » ('j') | no next file with comments »