Implement StreamTexture::BindTexImage.

content/common/gpu/client/command_buffer_proxy_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/client/command_buffer_proxy_impl.h"
 
 #include <vector>
 
 #include "base/callback.h"
 #include "base/logging.h"
@@ skipping 418 matching lines @@
   if (!buffer)
     return -1;
 
   return CreateImage(buffer->AsClientBuffer(), width, height, internalformat);
 }
 
 int CommandBufferProxyImpl::GetRouteID() const {
   return route_id_;
 }
 
 uint32 CommandBufferProxyImpl::CreateStreamTexture(uint32 texture_id) {

[no sievers, 2015/07/20 23:33:08]

Do we need to keep around the old version or can it all go away now?

   CheckLock();
   if (last_state_.error != gpu::error::kNoError)
     return 0;
 
   int32 stream_id = channel_->GenerateRouteID();
   bool succeeded = false;
   Send(new GpuCommandBufferMsg_CreateStreamTexture(
       route_id_, texture_id, stream_id, &succeeded));
   if (!succeeded) {
     DLOG(ERROR) << "GpuCommandBufferMsg_CreateStreamTexture returned failure";
     return 0;
   }
   return stream_id;
 }
 
+uint32 CommandBufferProxyImpl::CreateStreamTextureImage(int32 image_id) {

[no sievers, 2015/07/20 23:33:08]

It would be nice if we could return the image_id here instead of passing it in,
so that it works the same as CreateImage().

Maybe we can make |stream_id| internal to StreamTextureHost somehow, otherwise
it's confusing to have two ids in the API.

We can probably do it by just shuffling code around a bit in between
StreamTextureFactory/Proxy and StreamTextureHost (EstablishPeer and SetSize
would go through StreamTextureProxy instead, so outside of proxy/host nobody
needs to know the stream/route id).

+  CheckLock();
+  if (last_state_.error != gpu::error::kNoError)
+    return 0;
+
+  int32 stream_id = channel_->GenerateRouteID();
+  bool succeeded = false;
+  Send(new GpuCommandBufferMsg_CreateStreamTextureImage(route_id_, image_id,
+                                                        stream_id, &succeeded));
+  if (!succeeded) {
+    DLOG(ERROR)
+        << "GpuCommandBufferMsg_CreateStreamTextureImage returned failure";
+    return 0;
+  }
+  return stream_id;
+}
+
 void CommandBufferProxyImpl::SetLock(base::Lock* lock) {
   lock_ = lock;
 }
 
 bool CommandBufferProxyImpl::IsGpuChannelLost() {
   return !channel_ || channel_->IsLost();
 }
 
 uint32 CommandBufferProxyImpl::InsertSyncPoint() {
   CheckLock();
@@ skipping 160 matching lines @@
   }
 }
 
 void CommandBufferProxyImpl::OnUpdateVSyncParameters(base::TimeTicks timebase,
                                                      base::TimeDelta interval) {
   if (!update_vsync_parameters_completion_callback_.is_null())
     update_vsync_parameters_completion_callback_.Run(timebase, interval);
 }
 
 }  // namespace content