Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1129943004: Initial CL to create Reorder command builder behind a flag (Closed)

Created:
5 years, 7 months ago by joshua.litt
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Initial CL to create Reorder command builder behind a flag BUG=skia: Committed: https://skia.googlesource.com/skia/+/3b58d75170508567436cce259384d336949407d4

Patch Set 1 #

Patch Set 2 : tweak #

Patch Set 3 : more tidying #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -10 lines) Patch
M gyp/gpu.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrCommandBuilder.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M src/gpu/GrCommandBuilder.cpp View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + src/gpu/GrReorderCommandBuilder.h View 1 2 2 chunks +18 lines, -7 lines 0 comments Download
A src/gpu/GrReorderCommandBuilder.cpp View 1 chunk +46 lines, -0 lines 0 comments Download
M src/gpu/GrTargetCommands.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
joshualitt
This is obviously very preliminary, but I wanted to get something landed we can all ...
5 years, 7 months ago (2015-05-06 21:08:03 UTC) #2
bsalomon
Amazing that this is so few lines of code. lgtm
5 years, 7 months ago (2015-05-07 17:29:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129943004/20001
5 years, 7 months ago (2015-05-07 17:31:09 UTC) #5
commit-bot: I haz the power
Failed to apply patch for src/gpu/GrReorderCommandBuilder.h: While running git apply --index -3 -p1; error: patch ...
5 years, 7 months ago (2015-05-07 17:31:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129943004/40001
5 years, 7 months ago (2015-05-07 17:52:24 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 18:14:39 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/3b58d75170508567436cce259384d336949407d4

Powered by Google App Engine
This is Rietveld 408576698