Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 11299328: Implement basic array prefetching hints in Hydrogen. (Closed)

Created:
8 years ago by yuqiang.xian%intel.com
Modified:
8 years ago
Reviewers:
Yang, Jakob Kummerow
CC:
v8-dev, hans
Visibility:
Public.

Description

Implement basic array prefetching hints in Hydrogen. Insert prefetch instructions for those array element accesses (reads) with the prefetch hints in IA32 Lithium code generator. With this CL Kraken reports 60% improvement on audio-dft on Atom, where huge amount of cache misses were observed before. Currently the write accesses are not prefetched, just in order to isolate the individual impacts.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+374 lines, -14 lines) Patch
src/hydrogen.h View 1 chunk +2 lines, -0 lines 0 comments Download
src/hydrogen.cc View 6 chunks +264 lines, -1 line 0 comments Download
src/hydrogen-instructions.h View 3 chunks +7 lines, -1 line 0 comments Download
src/hydrogen-instructions.cc View 2 chunks +3 lines, -0 lines 0 comments Download
src/ia32/lithium-codegen-ia32.h View 1 chunk +4 lines, -0 lines 0 comments Download
src/ia32/lithium-codegen-ia32.cc View 4 chunks +53 lines, -7 lines 0 comments Download
src/ia32/lithium-ia32.h View 1 chunk +7 lines, -2 lines 0 comments Download
src/ia32/lithium-ia32.cc View 4 chunks +31 lines, -2 lines 0 comments Download
src/lithium-allocator-inl.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
yuqiang.xian%intel.com
8 years ago (2012-12-04 08:12:38 UTC) #1
yuqiang.xian%intel.com
8 years ago (2012-12-04 08:47:30 UTC) #2
Message was sent while issue was closed.
On 2012/12/04 08:12:38, yuqiang.xian%intel.com wrote:

Some files are missing when uploading, so closed this entry. Sorry for the mess.

Powered by Google App Engine
This is Rietveld 408576698