Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 11299326: Revert 170660 (Closed)

Created:
8 years ago by benwells
Modified:
8 years ago
Reviewers:
benwells
CC:
chromium-reviews, sadrul, akalin, ben+watch_chromium.org, Raghu Simha, Aaron Boodman, davemoore+watch_chromium.org, oshima+watch_chromium.org, tzik+watch_chromium.org, chromium-apps-reviews_chromium.org, haitaol1, stevenjb+watch_chromium.org, kinuko+watch, tim (not reviewing), nkostylev+watch_chromium.org
Visibility:
Public.

Description

Revert 170660 This change causes shutdown crashes when chrome menu is used to exit. > Keep browser process alive while there are platform apps with background pages running. This does not happen on Android or ChromeOS builds: Android does not support browser process keep alive, and ChromeOS does not need or like it. > > This change prevents platform apps getting killed unceremoniously while they have background pages active. > > This also delays the process being shutdown after closing the last platform app window, as background pages are kept alive for 15 seconds after their last activity is completed. > > This change re-lands r165772 which caused problems on Google branded ChromeOS. This version does not add keep alives for ChromeOS and was tested on the ChromeOS try bots. > > TBR=davemoore@chromium.org for the ash launcher test change. > > BUG=155457 > TEST=Make sure platform apps can be used from the launcher without chrome windows open; make sure Chrome shuts down properly in all cases. > > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165772 > > Review URL: https://chromiumcodereview.appspot.com/11117011 TBR=benwells@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170891

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -522 lines) Patch
M chrome/browser/chromeos/extensions/external_filesystem_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/app_window/app_window_apitest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_apitest.cc View 7 chunks +3 lines, -11 lines 0 comments Download
M chrome/browser/extensions/api/dns/dns_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/identity/identity_apitest.cc View 13 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/media_galleries_private_apitest.cc View 3 chunks +39 lines, -35 lines 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_apitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/serial/serial_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/socket/socket_apitest.cc View 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/system_indicator/system_indicator_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/system_info_cpu/system_info_cpu_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/system_info_memory/system_info_memory_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/usb/usb_apitest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_apitest.h View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/browser/extensions/extension_apitest.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.h View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 4 chunks +0 lines, -39 lines 0 comments Download
M chrome/browser/extensions/extension_host.h View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_host.cc View 4 chunks +0 lines, -17 lines 0 comments Download
M chrome/browser/extensions/platform_app_browsertest.cc View 26 chunks +36 lines, -47 lines 0 comments Download
M chrome/browser/extensions/platform_app_browsertest_util.h View 2 chunks +3 lines, -12 lines 0 comments Download
M chrome/browser/extensions/platform_app_browsertest_util.cc View 4 chunks +29 lines, -25 lines 0 comments Download
D chrome/browser/extensions/platform_app_service.h View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/extensions/platform_app_service.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/extensions/platform_app_service_factory.h View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/extensions/platform_app_service_factory.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M chrome/browser/extensions/web_view_browsertest.cc View 5 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/profiles/profile_dependency_manager.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/apps_helper.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/test/integration/apps_helper.cc View 3 chunks +0 lines, -25 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_apps_sync_test.cc View 5 chunks +0 lines, -17 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_apps_sync_test.cc View 5 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 15 chunks +11 lines, -18 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/media_galleries_private/attachdetach/test.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/platform_apps/geometry/test.js View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/open_link/main.js View 1 chunk +0 lines, -2 lines 0 comments Download
MM chrome/test/data/extensions/platform_apps/windows_api_bounds/background.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
benwells
8 years ago (2012-12-04 05:18:19 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698