Issue 11299323: [imperative autofill] handle filling in <select>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11299323: [imperative autofill] handle filling in <select> (Closed)

Created:
8 years ago by Evan Stade

Modified:
8 years ago

Reviewers:
Ilya Sherman, Dan Beam

CC:
chromium-reviews, dhollowa+watch_chromium.org, dbeam+watch-autofill_chromium.org, darin-cc_chromium.org, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[imperative autofill] handle filling in <select> also, differentiate cancel from success in AutofillDialogController. BUG=157270 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171062

Patch Set 1 #

Patch Set 2 : typo fix #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -28 lines)			Patch
M	chrome/browser/ui/autofill/autofill_dialog_controller.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/autofill/autofill_dialog_controller.cc	View	1	3 chunks	+40 lines, -27 lines	1 comment	Download
M	chrome/renderer/autofill/autofill_agent.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dan Beam

the rest seems fine as well, wait for isherman@'s better review to come along https://codereview.chromium.org/11299323/diff/2001/chrome/browser/ui/autofill/autofill_dialog_controller.cc ...

8 years ago (2012-12-04 03:31:51 UTC) #2

LGTM, thanks :)

Expand Messages | Collapse Messages