Run Chrome OS accessibility histograms on main thread.

content/browser/accessibility/browser_accessibility_state_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/accessibility/browser_accessibility_state_impl.h"
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
 #include "base/timer.h"
 #include "content/public/browser/browser_thread.h"
@@ skipping 31 matching lines @@
           switches::kDisableRendererAccessibility)) {
     accessibility_mode_ = AccessibilityModeEditableTextOnly;
   }
 #endif  // defined(OS_WIN)
 
   if (CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kForceRendererAccessibility)) {
     accessibility_mode_ = AccessibilityModeComplete;
   }
 
+#if defined(OS_WIN)

[oshima, 2012/12/03 22:09:23]

From the stack trace, the problem seems to be chromeos specific.
Or other platforms (mac/linux) are accessing BrowserProcessImpl from non UI
threads as well?

[dmazzoni, 2012/12/03 23:32:30]

Currently there's no Mac-specific or Linux-specific code. The desire to do some
processing on another thread was motivated by Windows-only needs, so I think it
makes sense for Windows to be the special case - the main thread seems like a
more sensible default for future changes to other platforms.

+  // On Windows, UpdateHistogram calls some system functions with unknown
+  // runtime, so call it on the file thread to ensure there's no jank.
+  // Everything in that method must be safe to call on another thread.
+  BrowserThread::ID browser_thread = BrowserThread::FILE;
+#else
+  // On all other platforms, UpdateHistogram should be called on the main
+  // thread.
+  BrowserThread::ID browser_thread = BrowserThread::UI;

[oshima, 2012/12/03 22:09:23]

the name |browser_thread| doesn't make much sense. Can you use something like
histogram_update_thread?

[dmazzoni, 2012/12/03 23:32:30]

Done.

+#endif
+
   // UpdateHistogram only takes a couple of milliseconds, but run it on
   // the FILE thread to guarantee there's no jank.
   // And we need to AddRef() the leaky singleton so that Bind doesn't
   // delete it prematurely.

[oshima, 2012/12/03 22:09:23]

update this comment too. May be just move it inside OS_WIN?

[dmazzoni, 2012/12/03 23:32:30]

Thanks, meant to do that earlier. Done.

   AddRef();
   BrowserThread::PostDelayedTask(
-      BrowserThread::FILE, FROM_HERE,
+      browser_thread, FROM_HERE,
       base::Bind(&BrowserAccessibilityStateImpl::UpdateHistogram, this),
       base::TimeDelta::FromSeconds(kAccessibilityHistogramDelaySecs));
 }
 
 BrowserAccessibilityStateImpl::~BrowserAccessibilityStateImpl() {
 }
 
 void BrowserAccessibilityStateImpl::OnScreenReaderDetected() {
   if (CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kDisableRendererAccessibility)) {
@@ skipping 38 matching lines @@
 AccessibilityMode BrowserAccessibilityStateImpl::GetAccessibilityMode() {
   return accessibility_mode_;
 }
 
 void BrowserAccessibilityStateImpl::SetAccessibilityMode(
     AccessibilityMode mode) {
   accessibility_mode_ = mode;
 }
 
 }  // namespace content