Break CloudPolicyRefreshScheduler's dependency on PrefService.

chrome/browser/policy/cloud_policy_refresh_scheduler_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/callback.h"
 #include "base/compiler_specific.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
+#include "base/values.h"

[pastarmovj, 2012/12/04 12:20:38]

Do you need this include?

[Mattias Nissler (ping if slow), 2012/12/04 13:20:40]

No, removed.

 #include "chrome/browser/policy/cloud_policy_refresh_scheduler.h"
 #include "chrome/browser/policy/mock_cloud_policy_client.h"
 #include "chrome/browser/policy/mock_cloud_policy_store.h"
 #include "chrome/browser/policy/test_task_runner.h"
 #include "chrome/browser/prefs/browser_prefs.h"
-#include "chrome/common/pref_names.h"
-#include "chrome/test/base/testing_pref_service.h"
+#include "policy/policy_constants.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace em = enterprise_management;
 
 using testing::DoAll;
 using testing::Return;
 using testing::SaveArg;
 using testing::_;
 
 namespace policy {
 
 namespace {
 const int64 kPolicyRefreshRate = 4 * 60 * 60 * 1000;
 }  // namespace
 
 class CloudPolicyRefreshSchedulerTest : public testing::Test {
  protected:
   CloudPolicyRefreshSchedulerTest()
       : task_runner_(new TestTaskRunner()),
-        network_change_notifier_(net::NetworkChangeNotifier::CreateMock()) {
-    chrome::RegisterLocalState(&prefs_);
-    prefs_.SetInteger(prefs::kUserPolicyRefreshRate, kPolicyRefreshRate);
-  }
+        network_change_notifier_(net::NetworkChangeNotifier::CreateMock()) {}
 
   virtual void SetUp() OVERRIDE {
     client_.SetDMToken("token");
 
     // Set up the protobuf timestamp to be one minute in the past. Since the
     // protobuf field only has millisecond precision, we convert the actual
     // value back to get a millisecond-clamped time stamp for the checks below.
     store_.policy_.reset(new em::PolicyData());
     store_.policy_->set_timestamp(
         ((base::Time::NowFromSystemTime() - base::TimeDelta::FromMinutes(1)) -
          base::Time::UnixEpoch()).InMilliseconds());
     last_refresh_ =
         base::Time::UnixEpoch() +
         base::TimeDelta::FromMilliseconds(store_.policy_->timestamp());
 
     // Keep track of when the last task was posted.
     EXPECT_CALL(*task_runner_, PostDelayedTask(_, _, _))
         .WillRepeatedly(DoAll(SaveArg<1>(&last_callback_),
                               SaveArg<2>(&last_delay_),
                               Return(true)));
   }
 
   CloudPolicyRefreshScheduler* CreateRefreshScheduler() {
-    return new CloudPolicyRefreshScheduler(&client_, &store_, &prefs_,
-                                         prefs::kUserPolicyRefreshRate,
-                                         task_runner_);
+    CloudPolicyRefreshScheduler* scheduler =
+        new CloudPolicyRefreshScheduler(&client_, &store_, task_runner_);
+    scheduler->SetRefreshDelay(kPolicyRefreshRate);
+    return scheduler;
   }
 
   void NotifyIPAddressChanged() {
     net::NetworkChangeNotifier::NotifyObserversOfIPAddressChangeForTests();
     loop_.RunUntilIdle();
   }
 
   void CheckTiming(int64 expected_delay_ms) {
     base::Time now(base::Time::NowFromSystemTime());
     base::TimeDelta expected_delay(
         base::TimeDelta::FromMilliseconds(expected_delay_ms));
     EXPECT_GE(last_delay_, expected_delay - (now - last_refresh_));
     EXPECT_LE(last_delay_, expected_delay);
   }
 
   MessageLoop loop_;
   MockCloudPolicyClient client_;
   MockCloudPolicyStore store_;
-  TestingPrefService prefs_;
   scoped_refptr<TestTaskRunner> task_runner_;
   scoped_ptr<net::NetworkChangeNotifier> network_change_notifier_;
 
   // Base time for the refresh that the scheduler should be using.
   base::Time last_refresh_;
 
   base::Closure last_callback_;
   base::TimeDelta last_delay_;
 };
 
@@ skipping 33 matching lines @@
   last_callback_.Run();
 }
 
 TEST_F(CloudPolicyRefreshSchedulerTest, Unregistered) {
   client_.SetDMToken("");
   EXPECT_CALL(*task_runner_, PostDelayedTask(_, _, _)).Times(0);
   scoped_ptr<CloudPolicyRefreshScheduler> scheduler(CreateRefreshScheduler());
   client_.NotifyPolicyFetched();
   client_.NotifyRegistrationStateChanged();
   client_.NotifyClientError();
+  scheduler->SetRefreshDelay(12 * 60 * 60 * 1000);
   store_.NotifyStoreLoaded();
   store_.NotifyStoreError();
-  prefs_.SetInteger(prefs::kUserPolicyRefreshRate, 12 * 60 * 60 * 1000);
 }
 
 class CloudPolicyRefreshSchedulerSteadyStateTest
     : public CloudPolicyRefreshSchedulerTest {
  protected:
   CloudPolicyRefreshSchedulerSteadyStateTest()
-      : refresh_scheduler_(&client_, &store_, &prefs_,
-                           prefs::kUserPolicyRefreshRate, task_runner_) {}
+      : refresh_scheduler_(&client_, &store_, task_runner_) {}
 
   virtual void SetUp() OVERRIDE {
+    refresh_scheduler_.SetRefreshDelay(kPolicyRefreshRate);
     CloudPolicyRefreshSchedulerTest::SetUp();
     last_refresh_ = base::Time::NowFromSystemTime();
     client_.NotifyPolicyFetched();
     CheckTiming(kPolicyRefreshRate);
   }
 
   CloudPolicyRefreshScheduler refresh_scheduler_;
 };
 
 TEST_F(CloudPolicyRefreshSchedulerSteadyStateTest, OnPolicyFetched) {
@@ skipping 16 matching lines @@
   CheckTiming(kPolicyRefreshRate);
 }
 
 TEST_F(CloudPolicyRefreshSchedulerSteadyStateTest, OnStoreError) {
   EXPECT_CALL(*task_runner_, PostDelayedTask(_, _, _)).Times(0);
   store_.NotifyStoreError();
 }
 
 TEST_F(CloudPolicyRefreshSchedulerSteadyStateTest, RefreshDelayChange) {
   const int delay_short_ms = 5 * 60 * 1000;
-  prefs_.SetInteger(prefs::kUserPolicyRefreshRate, delay_short_ms);
+  refresh_scheduler_.SetRefreshDelay(delay_short_ms);
   CheckTiming(CloudPolicyRefreshScheduler::kRefreshDelayMinMs);
 
   const int delay_ms = 12 * 60 * 60 * 1000;
-  prefs_.SetInteger(prefs::kUserPolicyRefreshRate, delay_ms);
+  refresh_scheduler_.SetRefreshDelay(delay_ms);
   CheckTiming(delay_ms);
 
   const int delay_long_ms = 2 * 24 * 60 * 60 * 1000;
-  prefs_.SetInteger(prefs::kUserPolicyRefreshRate, delay_long_ms);
+  refresh_scheduler_.SetRefreshDelay(delay_long_ms);
   CheckTiming(CloudPolicyRefreshScheduler::kRefreshDelayMaxMs);
 }
 
 TEST_F(CloudPolicyRefreshSchedulerSteadyStateTest, OnIPAddressChanged) {
   NotifyIPAddressChanged();
   CheckTiming(kPolicyRefreshRate);
 
   client_.SetStatus(DM_STATUS_REQUEST_FAILED);
   NotifyIPAddressChanged();
   EXPECT_EQ(last_delay_, base::TimeDelta());
@@ skipping 64 matching lines @@
     EXPECT_EQ(base::TimeDelta(), last_delay_);
     EXPECT_TRUE(last_callback_.is_null());
   }
 }
 
 INSTANTIATE_TEST_CASE_P(CloudPolicyRefreshSchedulerClientErrorTest,
                         CloudPolicyRefreshSchedulerClientErrorTest,
                         testing::ValuesIn(kClientErrorTestCases));
 
 }  // namespace policy