runtime/vm/intermediate_language_ia32.cc - Issue 11299298: Cache lookups at megamorphic call sites in optimized code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 11299298: Cache lookups at megamorphic call sites in optimized code. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: One change I forgot. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_ia32.cc

diff --git a/runtime/vm/intermediate_language_ia32.cc b/runtime/vm/intermediate_language_ia32.cc

index 8a1e32f798e516089d3905f8724af31ea54326bb..b35c56d0cec1e271102da93e00494626b132e1e6 100644

--- a/runtime/vm/intermediate_language_ia32.cc

+++ b/runtime/vm/intermediate_language_ia32.cc

@@ -362,9 +362,9 @@ static void EmitEqualityAsInstanceCall(FlowGraphCompiler* compiler,

Immediate(reinterpret_cast<intptr_t>(Object::null()));

Label check_identity;

__ cmpl(Address(ESP, 0 * kWordSize), raw_null);

- __ j(EQUAL, &check_identity, Assembler::kNearJump);

+ __ j(EQUAL, &check_identity);

__ cmpl(Address(ESP, 1 * kWordSize), raw_null);

- __ j(EQUAL, &check_identity, Assembler::kNearJump);

+ __ j(EQUAL, &check_identity);

ICData& equality_ic_data = ICData::ZoneHandle();

if (compiler->is_optimizing() && FLAG_propagate_ic_data) {

« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »