Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: runtime/vm/intermediate_language_ia32.cc

Issue 11299298: Cache lookups at megamorphic call sites in optimized code. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: One change I forgot. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 344 matching lines...) Expand 10 before | Expand all | Expand 10 after
355 } 355 }
356 const String& operator_name = String::ZoneHandle(Symbols::EqualOperator()); 356 const String& operator_name = String::ZoneHandle(Symbols::EqualOperator());
357 const int kNumberOfArguments = 2; 357 const int kNumberOfArguments = 2;
358 const Array& kNoArgumentNames = Array::Handle(); 358 const Array& kNoArgumentNames = Array::Handle();
359 const int kNumArgumentsChecked = 2; 359 const int kNumArgumentsChecked = 2;
360 360
361 const Immediate raw_null = 361 const Immediate raw_null =
362 Immediate(reinterpret_cast<intptr_t>(Object::null())); 362 Immediate(reinterpret_cast<intptr_t>(Object::null()));
363 Label check_identity; 363 Label check_identity;
364 __ cmpl(Address(ESP, 0 * kWordSize), raw_null); 364 __ cmpl(Address(ESP, 0 * kWordSize), raw_null);
365 __ j(EQUAL, &check_identity, Assembler::kNearJump); 365 __ j(EQUAL, &check_identity);
366 __ cmpl(Address(ESP, 1 * kWordSize), raw_null); 366 __ cmpl(Address(ESP, 1 * kWordSize), raw_null);
367 __ j(EQUAL, &check_identity, Assembler::kNearJump); 367 __ j(EQUAL, &check_identity);
368 368
369 ICData& equality_ic_data = ICData::ZoneHandle(); 369 ICData& equality_ic_data = ICData::ZoneHandle();
370 if (compiler->is_optimizing() && FLAG_propagate_ic_data) { 370 if (compiler->is_optimizing() && FLAG_propagate_ic_data) {
371 ASSERT(!original_ic_data.IsNull()); 371 ASSERT(!original_ic_data.IsNull());
372 if (original_ic_data.NumberOfChecks() == 0) { 372 if (original_ic_data.NumberOfChecks() == 0) {
373 // IC call for reoptimization populates original ICData. 373 // IC call for reoptimization populates original ICData.
374 equality_ic_data = original_ic_data.raw(); 374 equality_ic_data = original_ic_data.raw();
375 } else { 375 } else {
376 // Megamorphic call. 376 // Megamorphic call.
377 equality_ic_data = original_ic_data.AsUnaryClassChecks(); 377 equality_ic_data = original_ic_data.AsUnaryClassChecks();
(...skipping 2412 matching lines...) Expand 10 before | Expand all | Expand 10 after
2790 __ pcmpeqq(XMM0, XMM0); // Generate all 1's. 2790 __ pcmpeqq(XMM0, XMM0); // Generate all 1's.
2791 __ pxor(value, XMM0); 2791 __ pxor(value, XMM0);
2792 } 2792 }
2793 2793
2794 2794
2795 } // namespace dart 2795 } // namespace dart
2796 2796
2797 #undef __ 2797 #undef __
2798 2798
2799 #endif // defined TARGET_ARCH_X64 2799 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698