Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 11299291: Fixes non-working secondary Hunspell suggestion mechanism as reported here: http://code.google.com/… (Closed)

Created:
8 years ago by michel.weimerskirch
Modified:
8 years ago
Reviewers:
Hironori Bono
CC:
chromium-reviews
Visibility:
Public.

Description

Fixes non-working secondary Hunspell suggestion mechanism as reported here: http://code.google.com/p/chromium/issues/detail?id=153249 The "REP" suggestions from Hunspell dictionaires were previously ignored. This adds a pointer to the bdict_reader into the "SuggestMgr" so that it can use the replacement table from the bdict file. Contributed by michel@weimerskirch.net

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -0 lines) Patch
M README.chromium View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/hunspell/hunspell.cxx View 1 chunk +4 lines, -0 lines 0 comments Download
M src/hunspell/suggestmgr.hxx View 2 chunks +8 lines, -0 lines 0 comments Download
M src/hunspell/suggestmgr.cxx View 3 chunks +53 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
commit-bot: I haz the power
No reviewers yet.
8 years ago (2012-12-02 09:44:23 UTC) #1
michel.weimerskirch
8 years ago (2012-12-02 09:51:58 UTC) #2
Hironori Bono
LGTM. Is it possible to update README.chromium to add the above description? Regards, Hironori Bono
8 years ago (2012-12-03 06:02:22 UTC) #3
michel.weimerskirch
Thank you for your reply. I have added the description to README.chromium, as suggested.
8 years ago (2012-12-03 09:56:07 UTC) #4
Hironori Bono
Greetings, Many thanks for your update. Your description looks great. (Is it possible to add ...
8 years ago (2012-12-04 02:42:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michel@weimerskirch.net/11299291/1005
8 years ago (2012-12-04 09:51:47 UTC) #6
commit-bot: I haz the power
8 years ago (2012-12-04 09:51:57 UTC) #7
Message was sent while issue was closed.
Change committed as 170918

Powered by Google App Engine
This is Rietveld 408576698