Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 11299284: Revert 170507 - Add public accounts to UserManager (Closed)

Created:
8 years ago by Ilya Sherman
Modified:
8 years ago
Reviewers:
bartfab (slow)
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert 170507 - Add public accounts to UserManager BUG=163690 This CL extends the UserManager to handle public accounts defined through policy. User pods are dynamically added and removed when the list of public accounts in policy changes. Any data belonging to obsolete accounts is also removed, taking care not to remove it prematurely if a user is currently logged into the account. The CL also makes the user list handling more robust by checking for duplicate entries in the user list prefs and logging these as errors. The pods added for public accounts are not functional yet. The login flow for public accounts will be the topic of another CL. BUG=158509 Review URL: https://chromiumcodereview.appspot.com/11419184 TBR=bartfab@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170579

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -352 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/login/mock_user_manager.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.h View 5 chunks +6 lines, -30 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.cc View 17 chunks +102 lines, -267 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager_unittest.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/wallpaper_manager_browsertest.cc View 6 chunks +32 lines, -23 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_service.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/stub_cros_settings_provider.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 4 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Ilya Sherman
8 years ago (2012-11-30 22:33:15 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698