ui/views/controls/progress_bar.cc - Issue 11299262: ui: Use skia::RefPtr<T> for implicit safe reference counting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/progress_bar.cc

Issue 11299262: ui: Use skia::RefPtr<T> for implicit safe reference counting. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: nitted Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/progress_bar.cc

diff --git a/ui/views/controls/progress_bar.cc b/ui/views/controls/progress_bar.cc

index 1d7ad9d9d52d79aea4c4068891649ffce9d220cd..cab2991031bd004d1ab0e27587ee415a38c9385d 100644

--- a/ui/views/controls/progress_bar.cc

+++ b/ui/views/controls/progress_bar.cc

@@ -70,11 +70,9 @@ void FillRoundRect(gfx::Canvas* canvas,

} else {

p[1].iset(x, y + h);

}

- SkShader* s = SkGradientShader::CreateLinear(

- p, colors, points, count, SkShader::kClamp_TileMode, NULL);

- paint.setShader(s);

- // Need to unref shader, otherwise never deleted.

- s->unref();

+ skia::RefPtr<SkShader> s = skia::AdoptRef(SkGradientShader::CreateLinear(

+ p, colors, points, count, SkShader::kClamp_TileMode, NULL));

+ paint.setShader(s.get());

canvas->DrawPath(path, paint);

}