Issue 11299260: Object.observe: notify of __proto__ changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11299260: Object.observe: notify of proto changes (Closed)

Created:
8 years ago by adamk

Modified:
8 years ago

Reviewers:
rafaelw, rossberg

CC:
v8-dev, arv (Not doing code reviews)

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Object.observe: notify of __proto__ changes BUG=v8:2409 Committed: https://code.google.com/p/v8/source/detail?r=13141

Patch Set 2 : Fix naming and line length #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -5 lines)			Patch
	M	src/accessors.cc	View	1	2 chunks	+29 lines, -5 lines	0 comments	Download
	M	test/mjsunit/harmony/object-observe.js	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rossberg

LGTM with nits. https://codereview.chromium.org/11299260/diff/1/src/accessors.cc File src/accessors.cc (right): https://codereview.chromium.org/11299260/diff/1/src/accessors.cc#newcode794 src/accessors.cc:794: Handle<Object> new_proto(GetPrototypeSkipHiddenPrototypes(*receiver)); Nit: change to new_value ...

8 years ago (2012-12-03 13:37:41 UTC) #3

adamk

8 years ago (2012-12-03 19:07:05 UTC) #4

https://codereview.chromium.org/11299260/diff/1/src/accessors.cc
File src/accessors.cc (right):

https://codereview.chromium.org/11299260/diff/1/src/accessors.cc#newcode794
src/accessors.cc:794: Handle<Object>
new_proto(GetPrototypeSkipHiddenPrototypes(*receiver));
On 2012/12/03 13:37:41, rossberg wrote:
> Nit: change to new_value for symmetry (or the above to old_proto).

Done.

https://codereview.chromium.org/11299260/diff/1/test/mjsunit/harmony/object-o...
File test/mjsunit/harmony/object-observe.js (right):

https://codereview.chromium.org/11299260/diff/1/test/mjsunit/harmony/object-o...
test/mjsunit/harmony/object-observe.js:829: { object: obj, name: '__proto__',
type: 'prototype', oldValue: Object.prototype },
On 2012/12/03 13:37:41, rossberg wrote:
> Line length.

Done.

Expand Messages | Collapse Messages

Issue 11299260: Object.observe: notify of __proto__ changes (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix naming and line length #

Messages

Issue 11299260: Object.observe: notify of proto changes (Closed)