Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: src/global-handles.h

Issue 11299248: Unify object groups iteration in global handles. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Ulan Degenbaev. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/global-handles.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 void IterateNewSpaceStrongAndDependentRoots(ObjectVisitor* v); 199 void IterateNewSpaceStrongAndDependentRoots(ObjectVisitor* v);
200 200
201 // Finds weak independent or partially independent handles satisfying 201 // Finds weak independent or partially independent handles satisfying
202 // the callback predicate and marks them as pending. See the note above. 202 // the callback predicate and marks them as pending. See the note above.
203 void IdentifyNewSpaceWeakIndependentHandles(WeakSlotCallbackWithHeap f); 203 void IdentifyNewSpaceWeakIndependentHandles(WeakSlotCallbackWithHeap f);
204 204
205 // Iterates over weak independent or partially independent handles. 205 // Iterates over weak independent or partially independent handles.
206 // See the note above. 206 // See the note above.
207 void IterateNewSpaceWeakIndependentRoots(ObjectVisitor* v); 207 void IterateNewSpaceWeakIndependentRoots(ObjectVisitor* v);
208 208
209 // Iterate over objects in object groups that have at least one object
210 // which requires visiting. The callback has to return true if objects
211 // can be skipped and false otherwise.
212 bool IterateObjectGroups(ObjectVisitor* v, WeakSlotCallbackWithHeap can_skip);
213
209 // Add an object group. 214 // Add an object group.
210 // Should be only used in GC callback function before a collection. 215 // Should be only used in GC callback function before a collection.
211 // All groups are destroyed after a garbage collection. 216 // All groups are destroyed after a garbage collection.
212 void AddObjectGroup(Object*** handles, 217 void AddObjectGroup(Object*** handles,
213 size_t length, 218 size_t length,
214 v8::RetainedObjectInfo* info); 219 v8::RetainedObjectInfo* info);
215 220
216 // Add an implicit references' group. 221 // Add an implicit references' group.
217 // Should be only used in GC callback function before a collection. 222 // Should be only used in GC callback function before a collection.
218 // All groups are destroyed after a mark-compact collection. 223 // All groups are destroyed after a mark-compact collection.
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
283 288
284 friend class Isolate; 289 friend class Isolate;
285 290
286 DISALLOW_COPY_AND_ASSIGN(GlobalHandles); 291 DISALLOW_COPY_AND_ASSIGN(GlobalHandles);
287 }; 292 };
288 293
289 294
290 } } // namespace v8::internal 295 } } // namespace v8::internal
291 296
292 #endif // V8_GLOBAL_HANDLES_H_ 297 #endif // V8_GLOBAL_HANDLES_H_
OLDNEW
« no previous file with comments | « no previous file | src/global-handles.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698