sdk/lib/_internal/compiler/implementation/compiler.dart - Issue 11299220: Add @JSName annotation for native fields and methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/compiler.dart

Issue 11299220: Add @JSName annotation for native fields and methods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fix _NodeList Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/apiimpl.dart ('k') | sdk/lib/_internal/compiler/implementation/dart2js.dart » ('j') | sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/compiler.dart

diff --git a/sdk/lib/_internal/compiler/implementation/compiler.dart b/sdk/lib/_internal/compiler/implementation/compiler.dart

index e770cff2319056437c6eff12c693a9ed17a56240..996d52f5ed54622fc7bb0589e764cc020310dd87 100644

--- a/sdk/lib/_internal/compiler/implementation/compiler.dart

+++ b/sdk/lib/_internal/compiler/implementation/compiler.dart

@@ -493,8 +493,11 @@ abstract class Compiler implements DiagnosticListener {

|| libraryName == 'dart:math'

|| libraryName == 'dart:html'

|| libraryName == 'dart:svg') {

- if (libraryName == 'dart:html' || libraryName == 'dart:mirrors') {

- // dart:html needs access to convertDartClosureToJS.

+ if (libraryName == 'dart:html' ||

ngeoffray 2012/11/28 20:31:23 Please keep the style used lines 491-495. Otherwis

+ libraryName == 'dart:svg' ||

+ libraryName == 'dart:mirrors') {

+ // dart:html and dart:svg need access to convertDartClosureToJS and

+ // annotation classes.

// dart:mirrors needs access to the Primitives class.

importHelperLibrary(library);

}