Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: sdk/lib/_internal/compiler/implementation/elements/elements.dart

Issue 11299220: Add @JSName annotation for native fields and methods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/elements/elements.dart
diff --git a/sdk/lib/_internal/compiler/implementation/elements/elements.dart b/sdk/lib/_internal/compiler/implementation/elements/elements.dart
index 44112048363739ad1362a00875ddf5e40cb3c253..afd1869589231772cb93410a03365cb1daef31d5 100644
--- a/sdk/lib/_internal/compiler/implementation/elements/elements.dart
+++ b/sdk/lib/_internal/compiler/implementation/elements/elements.dart
@@ -355,9 +355,11 @@ class Element implements Spannable {
}
}
- bool _isNative = false;
- void setNative() { _isNative = true; }
- bool isNative() => _isNative;
+ String _nativeName = null;
ahe 2012/11/29 09:19:26 Please follow this layout of class definitions: f
sra1 2012/12/04 01:31:31 Sure, but (1) I was following existing style (2) w
+ bool isNative() => _nativeName != null;
+ String nativeName() => _nativeName;
+ /// Marks this element as a native element.
+ void setNative(String name) { _nativeName = name; }
FunctionElement asFunctionElement() => null;
@@ -1439,7 +1441,7 @@ abstract class ClassElement extends ScopeContainerElement
DartType supertype;
DartType defaultClass;
Link<DartType> interfaces;
- SourceString nativeName;
+ SourceString nativeTagInfo;
int supertypeLoadState;
int resolutionState;
@@ -1787,7 +1789,7 @@ abstract class ClassElement extends ScopeContainerElement
}
bool isInterface() => false;
- bool isNative() => nativeName != null;
+ bool isNative() => nativeTagInfo != null;
int get hashCode => id;
Scope buildScope() => new ClassScope(enclosingElement.buildScope(), this);

Powered by Google App Engine
This is Rietveld 408576698