Allow incremental marking when expose_gc is turned on.

Allow incremental marking when expose_gc is turned on.


BUG=

Committed: https://code.google.com/p/v8/source/detail?r=13072

[Michael Starzinger, 2012-11-22 10:17:02]

https://codereview.chromium.org/11299154/diff/2001/src/extensions/gc-extensio...
File src/extensions/gc-extension.cc (right):

https://codereview.chromium.org/11299154/diff/2001/src/extensions/gc-extensio...
src/extensions/gc-extension.cc:47: SetFlags(Heap::kAbortIncrementalMarkingMask);
You should just pass the GC flag directly in the call. Passing it like this is
basically a NOP, because it will be overridden by the subsequent GC call.

https://codereview.chromium.org/11299154/diff/2001/src/heap.cc
File src/heap.cc (left):

https://codereview.chromium.org/11299154/diff/2001/src/heap.cc#oldcode5325
src/heap.cc:5325: if (hint >= mark_sweep_time && !FLAG_expose_gc &&
Ulan, could you look at the IdelNotification changes?

[Hannes Payer (out of office), 2012-11-22 10:21:34]

https://codereview.chromium.org/11299154/diff/2001/src/extensions/gc-extensio...
File src/extensions/gc-extension.cc (right):

https://codereview.chromium.org/11299154/diff/2001/src/extensions/gc-extensio...
src/extensions/gc-extension.cc:47: SetFlags(Heap::kAbortIncrementalMarkingMask);
On 2012/11/22 10:17:02, Michael Starzinger wrote:
> You should just pass the GC flag directly in the call. Passing it like this is
> basically a NOP, because it will be overridden by the subsequent GC call.

Done.

[Michael Starzinger, 2012-11-23 09:15:16]

In general I am totally fine with this change, and it is definitely the way to
go. But as discussed offline, it will affect page cycler results (maybe
heavily).

So we should think about landing this as a point release on trunk, with just
this one change. That way we can warn perf-sheriffs that they should just
rebaseline page cyclers after this change and also make sure that we don't hide
real regressions with this.

@danno: What do think?

[Michael Starzinger, 2012-11-27 17:02:06]

LGTM. Let's land this and I will spin a point-release later.