Revert 169164 - Allow multiple object proxies to handle NameOwnerChanged

dbus/signal_sender_verification_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
 #include "base/metrics/histogram.h"
 #include "base/metrics/histogram_samples.h"
 #include "base/metrics/statistics_recorder.h"
@@ skipping 33 matching lines @@
     bus_options.dbus_thread_message_loop_proxy =
         dbus_thread_->message_loop_proxy();
     bus_ = new dbus::Bus(bus_options);
     object_proxy_ = bus_->GetObjectProxy(
         "org.chromium.TestService",
         dbus::ObjectPath("/org/chromium/TestObject"));
     ASSERT_TRUE(bus_->HasDBusThread());
 
     object_proxy_->SetNameOwnerChangedCallback(
         base::Bind(&SignalSenderVerificationTest::OnNameOwnerChanged,
-                   base::Unretained(this),
-                   &on_name_owner_changed_called_));
+                   base::Unretained(this)));
 
     // Connect to the "Test" signal of "org.chromium.TestInterface" from
     // the remote object.
     object_proxy_->ConnectToSignal(
         "org.chromium.TestInterface",
         "Test",
         base::Bind(&SignalSenderVerificationTest::OnTestSignal,
                    base::Unretained(this)),
         base::Bind(&SignalSenderVerificationTest::OnConnected,
                    base::Unretained(this)));
@@ skipping 47 matching lines @@
         FROM_HERE,
         base::Bind(&SignalSenderVerificationTest::OnOwnershipInternal,
                    base::Unretained(this)));
   }
 
   void OnOwnershipInternal() {
     on_ownership_called_ = true;
     message_loop_.Quit();
   }
 
-  void OnNameOwnerChanged(bool* called_flag, dbus::Signal* signal) {
+  void OnNameOwnerChanged(dbus::Signal* signal) {
     dbus::MessageReader reader(signal);
     std::string name, old_owner, new_owner;
     ASSERT_TRUE(reader.PopString(&name));
     ASSERT_TRUE(reader.PopString(&old_owner));
     ASSERT_TRUE(reader.PopString(&new_owner));
     latest_name_owner_ = new_owner;
-    *called_flag = true;
+    on_name_owner_changed_called_ = true;
     message_loop_.Quit();
   }
 
+ protected:
+
   // Called when the "Test" signal is received, in the main thread.
   // Copy the string payload to |test_signal_string_|.
   void OnTestSignal(dbus::Signal* signal) {
     dbus::MessageReader reader(signal);
     ASSERT_TRUE(reader.PopString(&test_signal_string_));
     message_loop_.Quit();
   }
 
   // Called when connected to the signal.
   void OnConnected(const std::string& interface_name,
                    const std::string& signal_name,
                    bool success) {
     ASSERT_TRUE(success);
     message_loop_.Quit();
   }
 
- protected:
-
   // Wait for the hey signal to be received.
   void WaitForTestSignal() {
     // OnTestSignal() will quit the message loop.
     message_loop_.Run();
   }
 
   MessageLoop message_loop_;
   scoped_ptr<base::Thread> dbus_thread_;
   scoped_refptr<dbus::Bus> bus_;
   dbus::ObjectProxy* object_proxy_;
@@ skipping 77 matching lines @@
   // latest_name_owner_ becomes non empty as the new owner appears.
   ASSERT_FALSE(latest_name_owner_.empty());
 
   // Now the second service owns the name.
   const char kNewMessage[] = "hello, new world";
 
   test_service2_->SendTestSignal(kNewMessage);
   WaitForTestSignal();
   ASSERT_EQ(kNewMessage, test_signal_string_);
 }
-
-TEST_F(SignalSenderVerificationTest, TestMultipleObjects) {
-  const char kMessage[] = "hello, world";
-
-  dbus::ObjectProxy* object_proxy2 = bus_->GetObjectProxy(
-      "org.chromium.TestService",
-      dbus::ObjectPath("/org/chromium/DifferentObject"));
-
-  bool second_name_owner_changed_called = false;
-  object_proxy2->SetNameOwnerChangedCallback(
-      base::Bind(&SignalSenderVerificationTest::OnNameOwnerChanged,
-                 base::Unretained(this),
-                 &second_name_owner_changed_called));
-
-  // Connect to a signal on the additional remote object to trigger the
-  // name owner matching.
-  object_proxy2->ConnectToSignal(
-      "org.chromium.DifferentTestInterface",
-      "Test",
-      base::Bind(&SignalSenderVerificationTest::OnTestSignal,
-                 base::Unretained(this)),
-      base::Bind(&SignalSenderVerificationTest::OnConnected,
-                 base::Unretained(this)));
-  // Wait until the object proxy is connected to the signal.
-  message_loop_.Run();
-
-  // Send the test signal from the exported object.
-  test_service_->SendTestSignal(kMessage);
-  // Receive the signal with the object proxy. The signal is handled in
-  // SignalSenderVerificationTest::OnTestSignal() in the main thread.
-  WaitForTestSignal();
-  ASSERT_EQ(kMessage, test_signal_string_);
-
-  // Release and acquire the name ownership.
-  // latest_name_owner_ should be non empty as |test_service_| owns the name.
-  ASSERT_FALSE(latest_name_owner_.empty());
-  test_service_->ShutdownAndBlock();
-  // OnNameOwnerChanged will PostTask to quit the message loop.
-  message_loop_.Run();
-  // latest_name_owner_ should be empty as the owner is gone.
-  ASSERT_TRUE(latest_name_owner_.empty());
-
-  // Reset the flag as NameOwnerChanged is already received in setup.
-  on_name_owner_changed_called_ = false;
-  second_name_owner_changed_called = false;
-  test_service2_->RequestOwnership(
-      base::Bind(&SignalSenderVerificationTest::OnOwnership,
-                 base::Unretained(this), true));
-  // Both of OnNameOwnerChanged() and OnOwnership() should quit the MessageLoop,
-  // but there's no expected order of those 2 event.
-  message_loop_.Run();
-  if (!on_name_owner_changed_called_ || !on_ownership_called_)
-    message_loop_.Run();
-  ASSERT_TRUE(on_name_owner_changed_called_);
-  ASSERT_TRUE(on_ownership_called_);
-
-  // The callback for the second object must have also been called in the
-  // same dispatch as for the first.
-  ASSERT_TRUE(second_name_owner_changed_called);
-
-  // latest_name_owner_ becomes non empty as the new owner appears.
-  ASSERT_FALSE(latest_name_owner_.empty());
-
-  // Now the second service owns the name.
-  const char kNewMessage[] = "hello, new world";
-
-  test_service2_->SendTestSignal(kNewMessage);
-  WaitForTestSignal();
-  ASSERT_EQ(kNewMessage, test_signal_string_);
-}