Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1129913004: Add a check that the planned replacement for page id for updating the history offset works. (Closed)

Created:
5 years, 7 months ago by Avi (use Gerrit)
Modified:
5 years, 7 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@classify
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a check that the planned replacement for page id for updating the history offset works. BUG=369661 TEST=All navigation tests remain green. Committed: https://crrev.com/9dd5e2a325cadbd52d43fc518b4204c46f1598a8 Cr-Commit-Position: refs/heads/master@{#329253}

Patch Set 1 #

Patch Set 2 : backward! #

Patch Set 3 : and more accurate! #

Patch Set 4 : a bit cleaner #

Patch Set 5 : check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M content/renderer/render_frame_impl.cc View 1 2 3 4 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Avi (use Gerrit)
OK, this is a good replacement.
5 years, 7 months ago (2015-05-09 20:53:12 UTC) #2
Charlie Reis
LGTM. Want to make it a CHECK so that we get crash reports if it ...
5 years, 7 months ago (2015-05-11 21:16:26 UTC) #3
Avi (use Gerrit)
On 2015/05/11 21:16:26, Charlie Reis wrote: > LGTM. Want to make it a CHECK so ...
5 years, 7 months ago (2015-05-11 21:18:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129913004/80001
5 years, 7 months ago (2015-05-11 21:23:51 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 7 months ago (2015-05-11 22:26:16 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 22:27:30 UTC) #9
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/9dd5e2a325cadbd52d43fc518b4204c46f1598a8
Cr-Commit-Position: refs/heads/master@{#329253}

Powered by Google App Engine
This is Rietveld 408576698