Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 11299121: Remove abstract from class members in dart libraries (Closed)

Created:
8 years, 1 month ago by hausner
Modified:
8 years, 1 month ago
Reviewers:
floitsch, srdjan
CC:
reviews_dartlang.org, floitsch
Visibility:
Public.

Description

Remove abstract from class members in dart libraries Add VM flag to produce compile error for explicitly defined abstract class members. Committed: https://code.google.com/p/dart/source/detail?r=15210

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -28 lines) Patch
M runtime/bin/socket_patch.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/lib/byte_array.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/parser.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M sdk/lib/core/comparable.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/double.dart View 4 chunks +14 lines, -14 lines 0 comments Download
M sdk/lib/core/hashable.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/math/random.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/utf/utf16.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/utf/utf32.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
8 years, 1 month ago (2012-11-20 23:31:57 UTC) #1
srdjan
lgtm
8 years, 1 month ago (2012-11-21 00:23:46 UTC) #2
floitsch
8 years, 1 month ago (2012-11-21 12:30:02 UTC) #3
LGTM.

Powered by Google App Engine
This is Rietveld 408576698