Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 11299102: Remove the legacy --additional-compiler-flags option from test.py (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tools/testing/dart/test_options.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for enumerating and preparing tests. 6 * Classes and methods for enumerating and preparing tests.
7 * 7 *
8 * This library includes: 8 * This library includes:
9 * 9 *
10 * - Creating tests by listing all the Dart files in certain directories, 10 * - Creating tests by listing all the Dart files in certain directories,
(...skipping 690 matching lines...) Expand 10 before | Expand all | Expand 10 after
701 // error should be reported by the compilation command. 701 // error should be reported by the compilation command.
702 } else if (configuration['runtime'] == 'd8') { 702 } else if (configuration['runtime'] == 'd8') {
703 commands.add(new Command(d8FileName, ['$tempDir/out.js'])); 703 commands.add(new Command(d8FileName, ['$tempDir/out.js']));
704 } else if (configuration['runtime'] == 'jsshell') { 704 } else if (configuration['runtime'] == 'jsshell') {
705 commands.add(new Command(jsShellFileName, ['$tempDir/out.js'])); 705 commands.add(new Command(jsShellFileName, ['$tempDir/out.js']));
706 } 706 }
707 return commands; 707 return commands;
708 708
709 case 'dart2dart': 709 case 'dart2dart':
710 var compilerArguments = new List.from(args); 710 var compilerArguments = new List.from(args);
711 var additionalFlags =
712 configuration['additional-compiler-flags'].split(' ');
713 for (final flag in additionalFlags) {
714 if (flag.isEmpty) continue;
715 compilerArguments.add(flag);
716 }
717 compilerArguments.add('--output-type=dart'); 711 compilerArguments.add('--output-type=dart');
718 String tempDir = createOutputDirectory(info.filePath, ''); 712 String tempDir = createOutputDirectory(info.filePath, '');
719 compilerArguments.add('--out=$tempDir/out.dart'); 713 compilerArguments.add('--out=$tempDir/out.dart');
720 List<Command> commands = 714 List<Command> commands =
721 <Command>[new Command(dartShellFileName, compilerArguments)]; 715 <Command>[new Command(dartShellFileName, compilerArguments)];
722 if (info.hasCompileError) { 716 if (info.hasCompileError) {
723 // Do not attempt to run the compiled result. A compilation 717 // Do not attempt to run the compiled result. A compilation
724 // error should be reported by the compilation command. 718 // error should be reported by the compilation command.
725 } else if (configuration['runtime'] == 'vm') { 719 } else if (configuration['runtime'] == 'vm') {
726 // TODO(antonm): support checked. 720 // TODO(antonm): support checked.
(...skipping 944 matching lines...) Expand 10 before | Expand all | Expand 10 after
1671 * $pass tests are expected to pass 1665 * $pass tests are expected to pass
1672 * $failOk tests are expected to fail that we won't fix 1666 * $failOk tests are expected to fail that we won't fix
1673 * $fail tests are expected to fail that we should fix 1667 * $fail tests are expected to fail that we should fix
1674 * $crash tests are expected to crash that we should fix 1668 * $crash tests are expected to crash that we should fix
1675 * $timeout tests are allowed to timeout 1669 * $timeout tests are allowed to timeout
1676 * $compileErrorSkip tests are skipped on browsers due to compile-time error 1670 * $compileErrorSkip tests are skipped on browsers due to compile-time error
1677 """; 1671 """;
1678 print(report); 1672 print(report);
1679 } 1673 }
1680 } 1674 }
OLDNEW
« no previous file with comments | « tools/testing/dart/test_options.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698