Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: tools/find_runtime_symbols/prepare_symbol_info.py

Issue 11299095: Add a first test for tools/find_runtime_symbols. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixed Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/find_runtime_symbols/find_runtime_symbols.py ('k') | tools/find_runtime_symbols/proc_maps.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/find_runtime_symbols/prepare_symbol_info.py
diff --git a/tools/find_runtime_symbols/prepare_symbol_info.py b/tools/find_runtime_symbols/prepare_symbol_info.py
index 0723de351b3e644d5251d4e491a3315f906b0945..9b1622555eca456893a4e696ca6346ddd3c8b6cc 100755
--- a/tools/find_runtime_symbols/prepare_symbol_info.py
+++ b/tools/find_runtime_symbols/prepare_symbol_info.py
@@ -27,7 +27,7 @@ def _dump_command_result(command, output_dir_path, basename, suffix):
try:
subprocess.check_call(
command, stdout=handle_out, stderr=handle_err, shell=True)
- except:
+ except (OSError, subprocess.CalledProcessError):
error = True
finally:
os.close(handle_err)
@@ -112,7 +112,7 @@ def prepare_symbol_info(maps_path, output_dir_path=None, use_tempdir=False):
LOGGER.info('Creating a new directory "%s".' % output_dir_path)
try:
os.mkdir(output_dir_path)
- except OSError, e:
+ except OSError:
LOGGER.warn('A directory "%s" cannot be created.' % output_dir_path)
if use_tempdir:
output_dir_path = tempfile.mkdtemp()
« no previous file with comments | « tools/find_runtime_symbols/find_runtime_symbols.py ('k') | tools/find_runtime_symbols/proc_maps.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698