runtime/vm/object.cc - Issue 11299084: Correct a misnomer regarding supplementary code points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.cc

Issue 11299084: Correct a misnomer regarding supplementary code points. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: missed a few uses of smp Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object.cc

diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc

index 612342ab7b4d53962340f35d332b726d65c01f52..81345b302d80f95076e308b062d729042be99e76 100644

--- a/runtime/vm/object.cc

+++ b/runtime/vm/object.cc

@@ -10160,7 +10160,7 @@ RawString* String::New(const uint8_t* utf8_array,

}

return strobj.raw();

}

- ASSERT((type == Utf8::kBMP) || (type == Utf8::kSMP));

+ ASSERT((type == Utf8::kBMP) || (type == Utf8::kSupplementary));

const String& strobj = String::Handle(TwoByteString::New(len, space));

NoGCScope no_gc;

Utf8::DecodeToUTF16(utf8_array, array_len,

« no previous file with comments | « no previous file | runtime/vm/object_test.cc » ('j') | no next file with comments »