chrome/renderer/translate_helper_browsertest.cc - Issue 11299062: chrome: Update the remaining calls from RunAllPending() to RunUntilIdle().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/translate_helper_browsertest.cc

Issue 11299062: chrome: Update the remaining calls from RunAllPending() to RunUntilIdle(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/spellchecker/spellcheck_unittest.cc ('k') | chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/translate_helper_browsertest.cc

diff --git a/chrome/renderer/translate_helper_browsertest.cc b/chrome/renderer/translate_helper_browsertest.cc

index b469f2436bb16a568909a7d91a136fe51ee6b50d..415d8690c5e03cb3d826930af0640e77d19e881c 100644

--- a/chrome/renderer/translate_helper_browsertest.cc

+++ b/chrome/renderer/translate_helper_browsertest.cc

@@ -96,7 +96,7 @@ TEST_F(TranslateHelperTest, TranslateLibNeverReady) {

translate_helper_->TranslatePage(

view_->GetPageId(), "en", "fr", std::string());

- MessageLoop::current()->RunAllPending();

+ MessageLoop::current()->RunUntilIdle();

int page_id;

TranslateErrors::Type error;

@@ -132,7 +132,7 @@ TEST_F(TranslateHelperTest, TranslateSuccess) {

std::string target_lang("fr");

translate_helper_->TranslatePage(

view_->GetPageId(), original_lang, target_lang, std::string());

- MessageLoop::current()->RunAllPending();

+ MessageLoop::current()->RunUntilIdle();

int page_id;

std::string received_original_lang;

@@ -175,7 +175,7 @@ TEST_F(TranslateHelperTest, TranslateFailure) {

translate_helper_->TranslatePage(

view_->GetPageId(), "en", "fr", std::string());

- MessageLoop::current()->RunAllPending();

+ MessageLoop::current()->RunUntilIdle();

int page_id;

TranslateErrors::Type error;

@@ -209,7 +209,7 @@ TEST_F(TranslateHelperTest, UndefinedSourceLang) {

translate_helper_->TranslatePage(view_->GetPageId(),

chrome::kUnknownLanguageCode, "fr",

std::string());

- MessageLoop::current()->RunAllPending();

+ MessageLoop::current()->RunUntilIdle();

int page_id;

TranslateErrors::Type error;

@@ -249,7 +249,7 @@ TEST_F(TranslateHelperTest, MultipleSimilarTranslations) {

// happens.

translate_helper_->TranslatePage(

view_->GetPageId(), original_lang, target_lang, std::string());

- MessageLoop::current()->RunAllPending();

+ MessageLoop::current()->RunUntilIdle();

int page_id;

std::string received_original_lang;

@@ -287,7 +287,7 @@ TEST_F(TranslateHelperTest, MultipleDifferentTranslations) {

std::string new_target_lang("de");

translate_helper_->TranslatePage(

view_->GetPageId(), original_lang, new_target_lang, std::string());

- MessageLoop::current()->RunAllPending();

+ MessageLoop::current()->RunUntilIdle();

int page_id;

std::string received_original_lang;