chrome/renderer/extensions/chrome_v8_context_set_unittest.cc - Issue 11299062: chrome: Update the remaining calls from RunAllPending() to RunUntilIdle().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/renderer/extensions/chrome_v8_context_set_unittest.cc

Issue 11299062: chrome: Update the remaining calls from RunAllPending() to RunUntilIdle(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/renderer/autofill/password_autofill_manager_browsertest.cc ('k') | chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/message_loop.h"	5 #include "base/message_loop.h"

6 #include "chrome/common/extensions/extension.h"	6 #include "chrome/common/extensions/extension.h"

7 #include "chrome/common/extensions/features/feature.h"	7 #include "chrome/common/extensions/features/feature.h"

8 #include "chrome/renderer/extensions/chrome_v8_context.h"	8 #include "chrome/renderer/extensions/chrome_v8_context.h"

9 #include "chrome/renderer/extensions/chrome_v8_context_set.h"	9 #include "chrome/renderer/extensions/chrome_v8_context_set.h"

10 #include "testing/gtest/include/gtest/gtest.h"	10 #include "testing/gtest/include/gtest/gtest.h"

(...skipping 34 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
45	45

46 context_set.Remove(context);	46 context_set.Remove(context);

47 EXPECT_EQ(0, context_set.size());	47 EXPECT_EQ(0, context_set.size());

48 EXPECT_FALSE(context_set.GetByV8Context(context->v8_context()));	48 EXPECT_FALSE(context_set.GetByV8Context(context->v8_context()));

49 EXPECT_EQ(1u, set_copy.size());	49 EXPECT_EQ(1u, set_copy.size());

50	50

51 // After removal, the context should be marked for destruction.	51 // After removal, the context should be marked for destruction.

52 EXPECT_FALSE(context->web_frame());	52 EXPECT_FALSE(context->web_frame());

53	53

54 // Run loop to do the actual deletion.	54 // Run loop to do the actual deletion.

55 loop.RunAllPending();	55 loop.RunUntilIdle();

56 }	56 }

57	57

58 } // namespace extensions	58 } // namespace extensions

OLD	NEW