Issue 11299042: MIPS trusted toolchain: Don't skip QEMU patch if the file is missing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11299042: MIPS trusted toolchain: Don't skip QEMU patch if the file is missing (Closed)

Created:
8 years, 1 month ago by Mark Seaborn

Modified:
7 years, 11 months ago

Reviewers:
petarj

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Visibility:
Public.

More Reviews

Description

MIPS trusted toolchain: Don't skip QEMU patch if the file is missing Skipping the patch just masks problems, such as if you haven't run "gclient sync" recently, because it builds a qemu-mips that doesn't handle the pread64() syscall properly. It should be an error if the patch file is missing. Also do a spelling fix. BUG=https://code.google.com/p/nativeclient/issues/detail?id=2275 TEST=none Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=10550

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -6 lines)			Patch
	M	tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh	View		1 chunk	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

On 2012/11/16 17:38:56, Mark Seaborn wrote:

lgtm

Expand Messages | Collapse Messages