Support manual (white|black)list, previewing and allowing after interstitial

chrome/browser/managed_mode/managed_mode.h

Index: chrome/browser/managed_mode/managed_mode.h
diff --git a/chrome/browser/managed_mode/managed_mode.h b/chrome/browser/managed_mode/managed_mode.h
index 7516f8219dff086d57575ef1af1f9db600ddb7b9..12b02e12c4097736e0c23a300ca00327fd137453 100644
--- a/chrome/browser/managed_mode/managed_mode.h
+++ b/chrome/browser/managed_mode/managed_mode.h
@@ -25,6 +25,9 @@ class ManagedModeURLFilter;
 class PrefChangeRegistrar;
 class PrefService;
 class Profile;
+namespace policy{

[Bernhard Bauer, 2012/11/16 15:04:46]

Please add a blank line before the namespace.

[Sergiu, 2012/11/26 14:48:08]

Done.

+class URLBlacklist;
+}
 
 // Managed mode allows one person to manage the Chrome experience for another
 // person by pre-configuring and then locking a managed User profile.
@@ -64,6 +67,19 @@ class ManagedMode : public chrome::BrowserListObserver,
   // Called in the critical path of drawing the history UI, so needs to be fast.
   static void GetCategoryNames(CategoryList* list);
 
+  // Returns the profile whitelist.

[Bernhard Bauer, 2012/11/16 15:04:46]

"[…] a copy of [the profile whitelist]"?

Also, it's not entirely clear what "profile whitelist" means here. Also, does
this need to be public?

[Sergiu, 2012/11/26 14:48:08]

Made it private, improved the comment.

+  static scoped_ptr<base::ListValue> GetWhitelist();
+
+  // Sets the profile whitelist to |whitelist|.
+  static void SetWhitelist(base::ListValue* whitelist);

[Bernhard Bauer, 2012/11/16 15:04:46]

What happens to the pointer that is passed in? Where is this used?

[Sergiu, 2012/11/26 14:48:08]

Deleted this function all together.

+
+  // Adds the |url| to the manual lists.

[Bernhard Bauer, 2012/11/16 15:04:46]

This is a URL *pattern*, right? So, we should call both the parameter that, and
update the method name accordingly.

[Sergiu, 2012/11/26 14:48:08]

Done.

+  static void AddStringToManualWhitelist(const std::string& url);
+  static void AddStringToManualBlacklist(const std::string& url);
+
+  // Returns the profile blacklist.
+  static scoped_ptr<base::ListValue> GetBlacklist();
+
   // ExtensionManagementPolicy::Provider implementation:
   virtual std::string GetDebugPolicyProviderName() const OVERRIDE;
   virtual bool UserMayLoad(const extensions::Extension* extension,