Support manual (white|black)list, previewing and allowing after interstitial

chrome/browser/managed_mode/managed_mode_resource_throttle.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/managed_mode/managed_mode_resource_throttle.h"
 
+#include "base/lazy_instance.h"
 #include "chrome/browser/managed_mode/managed_mode.h"
 #include "chrome/browser/managed_mode/managed_mode_interstitial.h"
 #include "chrome/browser/managed_mode/managed_mode_url_filter.h"
-#include "chrome/browser/policy/url_blacklist_manager.h"
 #include "content/public/browser/resource_controller.h"
 #include "net/url_request/url_request.h"
 
+namespace {
+
+// This map contains <render_process_host_id_, render_view_id> pairs mapped
+// to hostnames which identify individual tabs. If a hostname
+// is present for a specific pair then the user clicked preview, is
+// navigating around and has not clicked one of the options on the infobar.
+typedef std::map<std::pair<int, int>, std::string> PreviewMap;
+base::LazyInstance<PreviewMap> g_in_preview_mode = LAZY_INSTANCE_INITIALIZER;
+
+}
+
 ManagedModeResourceThrottle::ManagedModeResourceThrottle(
     const net::URLRequest* request,
     int render_process_host_id,
     int render_view_id,
     bool is_main_frame)
     : ALLOW_THIS_IN_INITIALIZER_LIST(weak_ptr_factory_(this)),
       request_(request),
       render_process_host_id_(render_process_host_id),
       render_view_id_(render_view_id),
       is_main_frame_(is_main_frame),
+      after_interstitial_(false),
       url_filter_(ManagedMode::GetURLFilterForIOThread()) {}
 
 ManagedModeResourceThrottle::~ManagedModeResourceThrottle() {}
 
-void ManagedModeResourceThrottle::WillStartRequest(bool* defer) {
-  if (url_filter_->GetFilteringBehaviorForURL(request_->url()) !=
+// static
+void ManagedModeResourceThrottle::AddTemporaryException(
+    int render_process_host_id,
+    int render_view_id,
+    const GURL& url) {
+  g_in_preview_mode.Get().insert(
+      std::make_pair(std::make_pair(render_process_host_id, render_view_id),
+                     url.host()));

[Pam (message me for reviews), 2012/12/06 15:11:56]

Is there not a more readable way to write this? std::map is pretty good about
using [].

[Sergiu, 2013/01/04 15:44:07]

Done.

+}
+
+// static
+void ManagedModeResourceThrottle::RemoveTemporaryException(
+      int render_process_host_id,
+      int render_view_id) {
+  g_in_preview_mode.Get().erase(std::make_pair(render_process_host_id,
+                                               render_view_id));
+}
+
+void ManagedModeResourceThrottle::ShowInterstitialIfNeeded(bool is_redirect,
+                                                           const GURL& url,
+                                                           bool* defer) {
+  // Only treat main frame requests for now (without subresources).

[Pam (message me for reviews), 2012/12/06 15:11:56]

This makes it sound like you only treat main-frame requests that don't have any
subresources. Try "ignoring subresources" or simply "not subresources".

[Sergiu, 2013/01/04 15:44:07]

Done.

+  if (!is_main_frame_)
+    return;
+
+  if (url_filter_->GetFilteringBehaviorForURL(url) !=
       ManagedModeURLFilter::BLOCK)
     return;

[Pam (message me for reviews), 2012/12/06 15:11:56]

Using brackets with a multi-line condition would be more readable.

[Sergiu, 2013/01/04 15:44:07]

Done.

 
-  if (is_main_frame_) {
-    *defer = true;
-    ManagedModeInterstitial::ShowInterstitial(
-        render_process_host_id_, render_view_id_, request_->url(),
-        base::Bind(&ManagedModeResourceThrottle::OnInterstitialResult,
-                   weak_ptr_factory_.GetWeakPtr()));
-  } else {
-    // NOTREACHED();
-    // XXX
+  // Do not show interstitial for redirects in preview mode and URLs which have
+  // the same hostname as the one on which the user clicked "Preview" on.
+  PreviewMap* preview_map = g_in_preview_mode.Pointer();
+  if (after_interstitial_) {
+    DCHECK(is_redirect);
+    return;
   }
+
+  PreviewMap::iterator it = preview_map->find(
+      std::make_pair(render_process_host_id_, render_view_id_));
+  if (it != preview_map->end() && url.host() == it->second)
+    return;
+
+  *defer = true;
+  ManagedModeInterstitial::ShowInterstitial(
+      render_process_host_id_, render_view_id_, url,
+      base::Bind(&ManagedModeResourceThrottle::OnInterstitialResult,
+                 weak_ptr_factory_.GetWeakPtr()));
+}
+
+void ManagedModeResourceThrottle::WillStartRequest(bool* defer) {
+  ShowInterstitialIfNeeded(false, request_->url(), defer);
+}
+
+void ManagedModeResourceThrottle::WillRedirectRequest(const GURL& new_url,
+                                                      bool* defer) {
+  ShowInterstitialIfNeeded(true, new_url, defer);
 }
 
 void ManagedModeResourceThrottle::OnInterstitialResult(bool continue_request) {
   if (continue_request) {
+    after_interstitial_ = true;
     controller()->Resume();
   } else {
     controller()->Cancel();
   }
 }