chrome/browser/history/top_sites_factory.h - Issue 1129903008: NTP Zombie Code Slayer Part IV: Most Visited

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/top_sites_factory.h

Issue 1129903008: NTP Zombie Code Slayer Part IV: Most Visited (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: pref registration Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/history/top_sites_factory.h

diff --git a/chrome/browser/history/top_sites_factory.h b/chrome/browser/history/top_sites_factory.h

index 0f1e811c57f6e7bcee2314809cb73f65cc692cab..8794a11dd070b5f439558998f00f8e923303caef 100644

--- a/chrome/browser/history/top_sites_factory.h

+++ b/chrome/browser/history/top_sites_factory.h

@@ -47,6 +47,8 @@ class TopSitesFactory : public RefcountedBrowserContextKeyedServiceFactory {

// Overridden from BrowserContextKeyedServiceFactory.

scoped_refptr<RefcountedKeyedService> BuildServiceInstanceFor(

content::BrowserContext* context) const override;

+ void RegisterProfilePrefs(

gab 2015/05/20 18:58:49 Where is this called from? I don't see any new cal

Dan Beam 2015/05/20 19:16:00 note the "override" https://code.google.com/p/chr

+ user_prefs::PrefRegistrySyncable* registry) override;

bool ServiceIsNULLWhileTesting() const override;

DISALLOW_COPY_AND_ASSIGN(TopSitesFactory);