NTP Zombie Code Slayer Part IV: Most Visited

chrome/browser/ui/webui/ntp/new_tab_page_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/ntp/new_tab_page_handler.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/metrics/histogram.h"
@@ skipping 50 matching lines @@
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback("bubblePromoViewed",
       base::Bind(&NewTabPageHandler::HandleBubblePromoViewed,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback("bubblePromoLinkClicked",
       base::Bind(&NewTabPageHandler::HandleBubblePromoLinkClicked,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback("pageSelected",
       base::Bind(&NewTabPageHandler::HandlePageSelected,
                  base::Unretained(this)));
-  web_ui()->RegisterMessageCallback("logTimeToClick",
-      base::Bind(&NewTabPageHandler::HandleLogTimeToClick,
-                 base::Unretained(this)));
 }
 
 void NewTabPageHandler::HandleNotificationPromoClosed(
     const base::ListValue* args) {
   UMA_HISTOGRAM_ENUMERATION("NewTabPage.Promo.Notification",
                             PROMO_CLOSED, PROMO_ACTION_MAX);
   NotificationPromo::HandleClosed(NotificationPromo::NTP_NOTIFICATION_PROMO);
   Notify(chrome::NOTIFICATION_PROMO_RESOURCE_STATE_CHANGED);
 }
 
@@ skipping 52 matching lines @@
   UMA_HISTOGRAM_ENUMERATION("NewTabPage.PreviousSelectedPageType",
                             previous_shown_page, kHistogramEnumerationMax);
 
   prefs->SetInteger(prefs::kNtpShownPage, page_id | index);
 
   int shown_page_type = page_id >> kPageIdOffset;
   UMA_HISTOGRAM_ENUMERATION("NewTabPage.SelectedPageType",
                             shown_page_type, kHistogramEnumerationMax);
 }
 
-void NewTabPageHandler::HandleLogTimeToClick(const base::ListValue* args) {
-  std::string histogram_name;
-  double duration;
-  if (!args->GetString(0, &histogram_name) || !args->GetDouble(1, &duration)) {
-    NOTREACHED();
-    return;
-  }
-
-  base::TimeDelta delta = base::TimeDelta::FromMilliseconds(duration);
-
-  if (histogram_name == "NewTabPage.TimeToClickMostVisited") {
-    UMA_HISTOGRAM_LONG_TIMES("NewTabPage.TimeToClickMostVisited", delta);
-  } else if (histogram_name == "ExtendedNewTabPage.TimeToClickMostVisited") {
-    UMA_HISTOGRAM_LONG_TIMES(
-        "ExtendedNewTabPage.TimeToClickMostVisited", delta);
-  } else {
-    NOTREACHED();
-  }
-}
-
 // static
 void NewTabPageHandler::RegisterProfilePrefs(
     user_prefs::PrefRegistrySyncable* registry) {
   // TODO(estade): should be syncable.
   registry->RegisterIntegerPref(prefs::kNtpShownPage, APPS_PAGE_ID);
 }
 
 // static
 void NewTabPageHandler::GetLocalizedValues(Profile* profile,
                                            base::DictionaryValue* values) {
-  values->SetInteger("most_visited_page_id", MOST_VISITED_PAGE_ID);
   values->SetInteger("apps_page_id", APPS_PAGE_ID);
 
   PrefService* prefs = profile->GetPrefs();
   int shown_page = prefs->GetInteger(prefs::kNtpShownPage);
   values->SetInteger("shown_page_type", shown_page & ~INDEX_MASK);
   values->SetInteger("shown_page_index", shown_page & INDEX_MASK);
 }
 
 void NewTabPageHandler::Notify(chrome::NotificationType notification_type) {
   content::NotificationService* service =
       content::NotificationService::current();
   service->Notify(notification_type,
                   content::Source<NewTabPageHandler>(this),
                   content::NotificationService::NoDetails());
 }