NTP Zombie Code Slayer Part IV: Most Visited

chrome/browser/resources/ntp4/apps_page.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('ntp', function() {
   'use strict';
 
   var APP_LAUNCH = {
     // The histogram buckets (keep in sync with extension_constants.h).
     NTP_APPS_MAXIMIZED: 0,
     NTP_APPS_COLLAPSED: 1,
     NTP_APPS_MENU: 2,
     NTP_MOST_VISITED: 3,
     NTP_APP_RE_ENABLE: 16,
     NTP_WEBSTORE_FOOTER: 18,
     NTP_WEBSTORE_PLUS_ICON: 19,
   };
 
   // Histogram buckets for UMA tracking of where a DnD drop came from.
   var DRAG_SOURCE = {
     SAME_APPS_PANE: 0,
     OTHER_APPS_PANE: 1,
-    MOST_VISITED_PANE: 2,
-    BOOKMARKS_PANE: 3,
+    MOST_VISITED_PANE: 2,  // Deprecated.
+    BOOKMARKS_PANE: 3,  // Deprecated.
     OUTSIDE_NTP: 4
   };
   var DRAG_SOURCE_LIMIT = DRAG_SOURCE.OUTSIDE_NTP + 1;
 
   /**
    * App context menu. The class is designed to be used as a singleton with
    * the app that is currently showing a context menu stored in this.app_.
    * @constructor
    */
   function AppContextMenu() {
@@ skipping 641 matching lines @@
           var samePageDrag = originalPage == this;
           sourceId = samePageDrag ? DRAG_SOURCE.SAME_APPS_PANE :
                                     DRAG_SOURCE.OTHER_APPS_PANE;
           this.tileGrid_.insertBefore(currentlyDraggingTile,
                                       this.tileElements_[index]);
           this.tileMoved(currentlyDraggingTile);
           if (!samePageDrag) {
             originalPage.fireRemovedEvent(currentlyDraggingTile, index, true);
             this.fireAddedEvent(currentlyDraggingTile, index, true);
           }
-        } else if (currentlyDraggingTile.querySelector('.most-visited')) {
-          this.generateAppForLink(tileContents.data);
-          sourceId = DRAG_SOURCE.MOST_VISITED_PANE;
         }
       } else {
         this.addOutsideData_(dataTransfer);
         sourceId = DRAG_SOURCE.OUTSIDE_NTP;
       }
 
       assert(sourceId != -1);
       chrome.send('metricsHandler:recordInHistogram',
           ['NewTabPage.AppsPageDragSource', sourceId, DRAG_SOURCE_LIMIT]);
     },
@@ skipping 79 matching lines @@
   function launchAppAfterEnable(appId) {
     chrome.send('launchApp', [appId, APP_LAUNCH.NTP_APP_RE_ENABLE]);
   }
 
   return {
     APP_LAUNCH: APP_LAUNCH,
     AppsPage: AppsPage,
     launchAppAfterEnable: launchAppAfterEnable,
   };
 });