Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: chrome/browser/history/DEPS

Issue 1129903008: NTP Zombie Code Slayer Part IV: Most Visited (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pref registration Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 include_rules = [ 1 include_rules = [
2 # History is being made into a Browser Component (http://crbug.com/370850), so 2 # History is being made into a Browser Component (http://crbug.com/370850), so
3 # we have these basic rules followed by temporary exceptions. Please don't 3 # we have these basic rules followed by temporary exceptions. Please don't
4 # add to the list of exceptions! 4 # add to the list of exceptions!
5 # 5 #
6 # Please send reviews to sdefresne@chromium.org when adding dependencies to 6 # Please send reviews to sdefresne@chromium.org when adding dependencies to
7 # this list. 7 # this list.
8 "-chrome/browser", 8 "-chrome/browser",
9 "-components", 9 "-components",
10 10
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 "+chrome/browser/bookmarks/chrome_bookmark_client_factory.h", 46 "+chrome/browser/bookmarks/chrome_bookmark_client_factory.h",
47 "+chrome/browser/content_settings/cookie_settings.h", 47 "+chrome/browser/content_settings/cookie_settings.h",
48 "+chrome/browser/history/android/android_provider_backend.h", 48 "+chrome/browser/history/android/android_provider_backend.h",
49 "+chrome/browser/signin/profile_oauth2_token_service_factory.h", 49 "+chrome/browser/signin/profile_oauth2_token_service_factory.h",
50 "+chrome/browser/signin/signin_manager_factory.h", 50 "+chrome/browser/signin/signin_manager_factory.h",
51 "+chrome/browser/sync/profile_sync_service.h", 51 "+chrome/browser/sync/profile_sync_service.h",
52 "+chrome/browser/sync/profile_sync_service_factory.h", 52 "+chrome/browser/sync/profile_sync_service_factory.h",
53 "+chrome/browser/ui/profile_error_dialog.h", 53 "+chrome/browser/ui/profile_error_dialog.h",
54 "+components/bookmarks/browser", 54 "+components/bookmarks/browser",
55 "+components/keyed_service/content", 55 "+components/keyed_service/content",
56 "+components/pref_registry",
56 ], 57 ],
57 # Those files will move to //components/history/content/browser and thus 58 # Those files will move to //components/history/content/browser and thus
58 # can depend on //content even indirectly. 59 # can depend on //content even indirectly.
59 'content_.*\.(cc|h)': [ 60 'content_.*\.(cc|h)': [
60 "+components/visitedlink/browser", 61 "+components/visitedlink/browser",
61 ], 62 ],
62 # TODO(sdefresne): Bring this list to zero. 63 # TODO(sdefresne): Bring this list to zero.
63 # 64 #
64 # Do not add to the list of temporarily-allowed dependencies below, 65 # Do not add to the list of temporarily-allowed dependencies below,
65 # and please do not introduce more #includes of these files. 66 # and please do not introduce more #includes of these files.
66 '.*_[a-z]*test\.cc': [ 67 '.*_[a-z]*test\.cc': [
67 "!chrome/browser/bookmarks/bookmark_model_factory.h", 68 "!chrome/browser/bookmarks/bookmark_model_factory.h",
68 "!chrome/browser/signin/profile_oauth2_token_service_factory.h", 69 "!chrome/browser/signin/profile_oauth2_token_service_factory.h",
69 "!chrome/browser/signin/signin_manager_factory.h", 70 "!chrome/browser/signin/signin_manager_factory.h",
70 "!chrome/browser/sync/profile_sync_service.h", 71 "!chrome/browser/sync/profile_sync_service.h",
71 "!chrome/browser/sync/profile_sync_service_factory.h", 72 "!chrome/browser/sync/profile_sync_service_factory.h",
72 "!chrome/browser/sync/profile_sync_service_mock.h", 73 "!chrome/browser/sync/profile_sync_service_mock.h",
73 "!components/bookmarks/test/bookmark_test_helpers.h", 74 "!components/bookmarks/test/bookmark_test_helpers.h",
74 ] 75 ]
75 } 76 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698