NTP Zombie Code Slayer Part IV: Most Visited

chrome/browser/resources/ntp4/new_tab.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview New tab page
  * This is the main code for the new tab page used by touch-enabled Chrome
  * browsers.  For now this is still a prototype.
  */
 
-/**
- * @typedef {{direction: string,
- *            filler: (boolean|undefined),
- *            title: string,
- *            url: string}}
- * @see chrome/browser/ui/webui/ntp/most_visited_handler.cc
- */
-var PageData;
-
 // Use an anonymous function to enable strict mode just for this file (which
 // will be concatenated with other files when embedded in Chrome
 cr.define('ntp', function() {
   'use strict';
 
   /**
    * NewTabView instance.
    * @type {!Object|undefined}
    */
   var newTabView;
@@ skipping 83 matching lines @@
       if (promoBubble)
         window.setTimeout(promoBubble.reposition.bind(promoBubble), 0);
     }
   };
 
   /**
    * Invoked at startup once the DOM is available to initialize the app.
    */
   function onLoad() {
     sectionsToWaitFor = 0;
-    if (loadTimeData.getBoolean('showMostvisited'))
-      sectionsToWaitFor++;
     if (loadTimeData.getBoolean('showApps')) {
       sectionsToWaitFor++;
       if (loadTimeData.getBoolean('showAppLauncherPromo')) {
         $('app-launcher-promo-close-button').addEventListener('click',
             function() { chrome.send('stopShowingAppLauncherPromo'); });
         $('apps-promo-learn-more').addEventListener('click',
             function() { chrome.send('onLearnMore'); });
       }
     }
     measureNavDots();
 
     // Load the current theme colors.
     themeChanged();
 
     newTabView = new NewTabView();
 
     notificationContainer = getRequiredElement('notification-container');
     notificationContainer.addEventListener(
         'webkitTransitionEnd', onNotificationTransitionEnd);
 
-    if (loadTimeData.getBoolean('showMostvisited')) {
-      var mostVisited = new ntp.MostVisitedPage();
-      // Move the footer into the most visited page if we are in "bare minimum"
-      // mode.
-      if (document.body.classList.contains('bare-minimum'))
-        mostVisited.appendFooter(getRequiredElement('footer'));
-      newTabView.appendTilePage(mostVisited,
-                                loadTimeData.getString('mostvisited'),
-                                false);
-      chrome.send('getMostVisited');
-    }
-
     if (!loadTimeData.getBoolean('showWebStoreIcon')) {
       var webStoreIcon = $('chrome-web-store-link');
       // Not all versions of the NTP have a footer, so this may not exist.
       if (webStoreIcon)
         webStoreIcon.hidden = true;
     } else {
       var webStoreLink = loadTimeData.getString('webStoreLink');
       var url = appendParam(webStoreLink, 'utm_source', 'chrome-ntp-launcher');
       $('chrome-web-store-link').href = url;
       $('chrome-web-store-link').addEventListener('click',
@@ skipping 152 matching lines @@
     measuringDiv.textContent = loadTimeData.getString(id);
     // The 4 is for border and padding.
     return Math.max(measuringDiv.clientWidth * 1.15 + 4, 80);
   }
 
   /**
    * Fills in an invisible div with the longest dot title string so that
    * its length may be measured and the nav dots sized accordingly.
    */
   function measureNavDots() {
-    var pxWidth = measureNavDot('appDefaultPageName');
-    if (loadTimeData.getBoolean('showMostvisited'))
-      pxWidth = Math.max(measureNavDot('mostvisited'), pxWidth);
-
     var styleElement = document.createElement('style');
     styleElement.type = 'text/css';
     // max-width is used because if we run out of space, the nav dots will be
     // shrunk.
+    var pxWidth = measureNavDot('appDefaultPageName');
     styleElement.textContent = '.dot { max-width: ' + pxWidth + 'px; }';
     document.querySelector('head').appendChild(styleElement);
   }
 
   /**
    * Layout the footer so that the nav dots stay centered.
    */
   function layoutFooter() {
     // We need the image to be loaded.
     var logo = $('logo-img');
@@ skipping 153 matching lines @@
    * When done fading out, set hidden to true so the notification can't be
    * tabbed to or clicked.
    * @param {Event} e The webkitTransitionEnd event.
    */
   function onNotificationTransitionEnd(e) {
     if (notificationContainer.classList.contains('inactive'))
       notificationContainer.hidden = true;
   }
 
   /**
-   * @param {Array<PageData>} data
-   * @param {boolean} hasBlacklistedUrls
-   */
-  function setMostVisitedPages(data, hasBlacklistedUrls) {
-    newTabView.mostVisitedPage.data = data;
-    cr.dispatchSimpleEvent(document, 'sectionready', true, true);
-  }
-
-  /**
    * Set the dominant color for a node. This will be called in response to
    * getFaviconDominantColor. The node represented by |id| better have a setter
    * for stripeColor.
    * @param {string} id The ID of a node.
    * @param {string} color The color represented as a CSS string.
    */
   function setFaviconDominantColor(id, color) {
     var node = $(id);
     if (node)
       node.stripeColor = color;
@@ skipping 38 matching lines @@
    * Show the sync login UI.
    * @param {Event} e The click event.
    */
   function showSyncLoginUI(e) {
     var rect = e.currentTarget.getBoundingClientRect();
     chrome.send('showSyncLoginUI',
                 [rect.left, rect.top, rect.width, rect.height]);
   }
 
   /**
-   * Logs the time to click for the specified item.
-   * @param {string} item The item to log the time-to-click.
-   */
-  function logTimeToClick(item) {
-    var timeToClick = Date.now() - startTime;
-    chrome.send('logTimeToClick',
-        ['NewTabPage.TimeToClick' + item, timeToClick]);
-  }
-
-  /**
    * Wrappers to forward the callback to corresponding PageListView member.
    */
 
   /**
    * Called by chrome when a new app has been added to chrome or has been
    * enabled if previously disabled.
    * @param {Object} appData A data structure full of relevant information for
    *     the app.
    * @param {boolean=} opt_highlight Whether the app about to be added should
    *     be highlighted.
@@ skipping 102 matching lines @@
     appMoved: appMoved,
     appRemoved: appRemoved,
     appsPrefChangeCallback: appsPrefChangeCallback,
     appLauncherPromoPrefChangeCallback: appLauncherPromoPrefChangeCallback,
     enterRearrangeMode: enterRearrangeMode,
     getAppsCallback: getAppsCallback,
     getAppsPageIndex: getAppsPageIndex,
     getCardSlider: getCardSlider,
     onLoad: onLoad,
     leaveRearrangeMode: leaveRearrangeMode,
-    logTimeToClick: logTimeToClick,
     NtpFollowAction: NtpFollowAction,
     saveAppPageName: saveAppPageName,
     setAppToBeHighlighted: setAppToBeHighlighted,
     setBookmarkBarAttached: setBookmarkBarAttached,
-    setMostVisitedPages: setMostVisitedPages,
     setFaviconDominantColor: setFaviconDominantColor,
     showNotification: showNotification,
     themeChanged: themeChanged,
     updateLogin: updateLogin
   };
 });
 
 document.addEventListener('DOMContentLoaded', ntp.onLoad);
 
 var toCssPx = cr.ui.toCssPx;