Attempt to fix Windows Dartium #2

runtime/vm/profiler.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/address_sanitizer.h"
 #include "platform/memory_sanitizer.h"
 #include "platform/utils.h"
 
 #include "vm/allocation.h"
 #include "vm/atomic.h"
@@ skipping 930 matching lines @@
   ASSERT(ep->ExceptionRecord->ExceptionInformation[0] == 0);
   return EXCEPTION_EXECUTE_HANDLER;
 }
 #endif
 
 // All memory access done to collect the sample is performed in CollectSample.
 static void CollectSample(Isolate* isolate,
                           bool exited_dart_code,
                           bool in_dart_code,
                           Sample* sample,
-                          uword stack_lower,
-                          uword stack_upper,
-                          uword pc,
-                          uword fp,
-                          uword sp) {
-  ProfilerNativeStackWalker nativeStackWalker(sample,
-                                              stack_lower,
-                                              stack_upper,
-                                              pc,
-                                              fp,
-                                              sp);
-
-  ProfilerDartExitStackWalker dartExitStackWalker(isolate, sample);
-
-  ProfilerDartStackWalker dartStackWalker(isolate,
-                                          sample,
-                                          stack_lower,
-                                          stack_upper,
-                                          pc,
-                                          fp,
-                                          sp);
-
+                          ProfilerNativeStackWalker* native_stack_walker,
+                          ProfilerDartExitStackWalker* dart_exit_stack_walker,
+                          ProfilerDartStackWalker* dart_stack_walker,
+                          uword pc) {
 #if defined(TARGET_OS_WINDOWS)
   // Use structured exception handling to trap guard page access on Windows.
   __try {
 #endif
 
   CopyStackBuffer(sample);
   CopyPCMarkerIfSafe(sample);
 
   if (FLAG_profile_vm) {
     // Always walk the native stack collecting both native and Dart frames.
-    nativeStackWalker.walk();
+    native_stack_walker->walk();
   } else if (exited_dart_code) {
     // We have a valid exit frame info, use the Dart stack walker.
-    dartExitStackWalker.walk();
+    dart_exit_stack_walker->walk();
   } else if (in_dart_code) {
     // We are executing Dart code. We have frame pointers.
-    dartStackWalker.walk();
+    dart_stack_walker->walk();
   } else {
     sample->set_vm_tag(VMTag::kEmbedderTagId);
     sample->SetAt(0, pc);
   }
 
 #if defined(TARGET_OS_WINDOWS)
   // Use structured exception handling to trap guard page access.
   } __except(GuardPageExceptionFilter(GetExceptionInformation())) {
     // Sample collection triggered a guard page fault:
     // 1) discard entire sample.
@@ skipping 147 matching lines @@
   // Increment counter for vm tag.
   VMTagCounters* counters = isolate->vm_tag_counters();
   ASSERT(counters != NULL);
   counters->Increment(vm_tag);
   sample->set_vm_tag(vm_tag);
   sample->set_user_tag(isolate->user_tag());
   sample->set_sp(sp);
   sample->set_fp(fp);
   sample->set_lr(lr);
 
+  ProfilerNativeStackWalker native_stack_walker(sample,
+                                                stack_lower,
+                                                stack_upper,
+                                                pc,
+                                                fp,
+                                                sp);
+
+  ProfilerDartExitStackWalker dart_exit_stack_walker(isolate, sample);
+
+  ProfilerDartStackWalker dart_stack_walker(isolate,
+                                            sample,
+                                            stack_lower,
+                                            stack_upper,
+                                            pc,
+                                            fp,
+                                            sp);
+
   // All memory access is done inside CollectSample.
   CollectSample(isolate,
                 exited_dart_code,
                 in_dart_code,
                 sample,
-                stack_lower,
-                stack_upper,
-                pc,
-                fp,
-                sp);
+                &native_stack_walker,
+                &dart_exit_stack_walker,
+                &dart_stack_walker,
+                pc);
 }
 
 }  // namespace dart