Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 1129903006: Don't attempt to revoke old refresh token on reauth. (Closed)

Created:
5 years, 7 months ago by Roger Tawa OOO till Jul 10th
Modified:
5 years, 7 months ago
Reviewers:
Mike Lerman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't attempt to revoke old refresh token on reauth. Since refresh tokens are now tagged with device id, this will invalidate the new refresh token as well. BUG=398971 Committed: https://crrev.com/f1f953d6ed8571724e9171efb4a1a2f6a4fe8d57 Cr-Commit-Position: refs/heads/master@{#330096}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M components/signin/core/browser/mutable_profile_oauth2_token_service.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Roger Tawa OOO till Jul 10th
Hi Mike, Please take a look. Thanks.
5 years, 7 months ago (2015-05-14 21:41:37 UTC) #2
Mike Lerman
Thanks for the offline discussion, to help me catch up :) lgtm!
5 years, 7 months ago (2015-05-15 13:52:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129903006/1
5 years, 7 months ago (2015-05-15 14:30:34 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 15:11:55 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 15:12:44 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1f953d6ed8571724e9171efb4a1a2f6a4fe8d57
Cr-Commit-Position: refs/heads/master@{#330096}

Powered by Google App Engine
This is Rietveld 408576698