runtime/vm/dart_api_impl.cc - Issue 11299020: Make creation of list literal more resilient to changes in the underlying

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 11299020: Make creation of list literal more resilient to changes in the underlying (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart_api_impl.cc

===================================================================

--- runtime/vm/dart_api_impl.cc (revision 14985)

+++ runtime/vm/dart_api_impl.cc (working copy)

@@ -1760,10 +1760,12 @@

static RawInstance* GetListInstance(Isolate* isolate, const Object& obj) {

if (obj.IsInstance()) {

const Instance& instance = Instance::Cast(obj);

- const Type& type =

- Type::Handle(isolate, isolate->object_store()->list_interface());

+ const Class& obj_class = Class::Handle(isolate, obj.clazz());

+ const Class& list_class =

+ Class::Handle(isolate, isolate->object_store()->list_class());

Error& malformed_type_error = Error::Handle(isolate);

- if (instance.IsInstanceOf(type,

+ if (obj_class.IsSubtypeOf(TypeArguments::Handle(isolate),

+ list_class,

TypeArguments::Handle(isolate),

&malformed_type_error)) {

ASSERT(malformed_type_error.IsNull()); // Type is a raw List.

« no previous file with comments | « runtime/vm/code_generator.cc ('k') | runtime/vm/flow_graph_builder.cc » ('j') | runtime/vm/flow_graph_compiler_ia32.cc » ('J')