Make creation of list literal more resilient to changes in the underlying

Make creation of list literal more resilient to changes in the underlying
dart implementation of List in the core library.
Do the same for map literal creation.
Committed: https://code.google.com/p/dart/source/detail?r=14997

[regis, 2012-11-16 01:33:40]

TBR

Submitted TBR, since I am out the office tomorrow and I do not want to block the
team.

[siva, 2012-11-16 02:24:50]

lgtm

https://codereview.chromium.org/11299020/diff/5002/runtime/vm/flow_graph_comp...
File runtime/vm/flow_graph_compiler_ia32.cc (right):

https://codereview.chromium.org/11299020/diff/5002/runtime/vm/flow_graph_comp...
runtime/vm/flow_graph_compiler_ia32.cc:161: if (type_class.raw() ==
Isolate::Current()->object_store()->list_class()) {
why not have a ListClass() helper in Class it would
make the code more readable.

https://codereview.chromium.org/11299020/diff/5002/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/11299020/diff/5002/runtime/vm/parser.cc#newco...
runtime/vm/parser.cc:8711: Type::Handle(Type::ArrayType()).type_class());
Why not just do
const Class& array_class = Class::Handle(
  Isolate::Current()->object_store()->array_class());

or if you had the helper method it would be
const Class& array_class = Class::Handle(Class::ListClass());

[regis, 2012-11-20 19:37:33]

Thanks!

https://codereview.chromium.org/11418098 on its way.

https://codereview.chromium.org/11299020/diff/5002/runtime/vm/flow_graph_comp...
File runtime/vm/flow_graph_compiler_ia32.cc (right):

https://codereview.chromium.org/11299020/diff/5002/runtime/vm/flow_graph_comp...
runtime/vm/flow_graph_compiler_ia32.cc:161: if (type_class.raw() ==
Isolate::Current()->object_store()->list_class()) {
On 2012/11/16 02:24:50, siva wrote:
> why not have a ListClass() helper in Class it would
> make the code more readable.

Done (in a follow-up cl).

https://codereview.chromium.org/11299020/diff/5002/runtime/vm/flow_graph_comp...
File runtime/vm/flow_graph_compiler_x64.cc (right):

https://codereview.chromium.org/11299020/diff/5002/runtime/vm/flow_graph_comp...
runtime/vm/flow_graph_compiler_x64.cc:161: if (type_class.raw() ==
Isolate::Current()->object_store()->list_class()) {
Done here too.

https://codereview.chromium.org/11299020/diff/5002/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/11299020/diff/5002/runtime/vm/parser.cc#newco...
runtime/vm/parser.cc:8711: Type::Handle(Type::ArrayType()).type_class());
On 2012/11/16 02:24:50, siva wrote:
> Why not just do
> const Class& array_class = Class::Handle(
>   Isolate::Current()->object_store()->array_class());
> 
> or if you had the helper method it would be
> const Class& array_class = Class::Handle(Class::ListClass());

The ListClass helper would be the wrong one here, since we want the class of
Array, not of List. I changed the code according to your first suggestion (in a
follow-up cl).