sdk/lib/_internal/compiler/implementation/ssa/codegen.dart - Issue 11299009: Support type literals as compile-time constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Issue 11299009: Support type literals as compile-time constants. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart b/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

index 3eba765941b136686c2c788bd4cd580628147f46..898a54c865defa32688952085222607adac24cd3 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

@@ -2485,7 +2485,9 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {

// [arguments.head].

js.PropertyAccess field =

new js.PropertyAccess.field(pop(), typeVariable.toString());

- js.Expression genericName = new js.LiteralString("'${arguments.head}'");

+ RuntimeTypeInformation rti = backend.rti;

+ String typeName = rti.buildStringRepresentation(arguments.head);

+ js.Expression genericName = new js.LiteralString("'$typeName'");

js.Binary eqTest = new js.Binary('===', field, genericName);

// Also test for 'undefined' in case the object does not have

// any type variable.