Remote service state handling

Remote service state handling

BUG=160939
TEST=DriveFileSyncServiceTest.*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168182

[kinuko, 2012-11-15 14:21:51]

I know this'd look less cuter than the the original code... anyway can you take
a look?

[tzik, 2012-11-16 03:34:26]

lgtm

[kinuko, 2012-11-16 04:43:36]

Updated the patch to add/fix more error code and removed origin-specific
description. (And cc-ing more ppl to have more eyes)  Can you take another look?

[tzik, 2012-11-16 05:21:51]

http://codereview.chromium.org/11299008/diff/8007/chrome/browser/sync_file_sy...
File chrome/browser/sync_file_system/drive_file_sync_service_unittest.cc
(right):

http://codereview.chromium.org/11299008/diff/8007/chrome/browser/sync_file_sy...
chrome/browser/sync_file_system/drive_file_sync_service_unittest.cc:23: using
::testing::AtLeast;
sort?

http://codereview.chromium.org/11299008/diff/8007/chrome/browser/sync_file_sy...
File chrome/browser/sync_file_system/remote_file_sync_service.h (right):

http://codereview.chromium.org/11299008/diff/8007/chrome/browser/sync_file_sy...
chrome/browser/sync_file_system/remote_file_sync_service.h:34: // local database
corruption, no available account on the remote
maybe, "no available account" causes authentication error, so it'll be interpret
as TEMPORARY_UNAVAILABLE.

http://codereview.chromium.org/11299008/diff/8007/chrome/browser/sync_file_sy...
chrome/browser/sync_file_system/remote_file_sync_service.h:62: 
Could you add getters for state and description?

[kinuko, 2012-11-16 05:45:02]

Thanks, updated.

http://codereview.chromium.org/11299008/diff/8007/chrome/browser/sync_file_sy...
File chrome/browser/sync_file_system/drive_file_sync_service_unittest.cc
(right):

http://codereview.chromium.org/11299008/diff/8007/chrome/browser/sync_file_sy...
chrome/browser/sync_file_system/drive_file_sync_service_unittest.cc:23: using
::testing::AtLeast;
On 2012/11/16 05:21:51, tzik wrote:
> sort?

Done.

http://codereview.chromium.org/11299008/diff/8007/chrome/browser/sync_file_sy...
File chrome/browser/sync_file_system/remote_file_sync_service.h (right):

http://codereview.chromium.org/11299008/diff/8007/chrome/browser/sync_file_sy...
chrome/browser/sync_file_system/remote_file_sync_service.h:34: // local database
corruption, no available account on the remote
Per offline chat I added yet another AUTHENTICATION_REQUIRED state (here and in
sync_event_observer.h)

http://codereview.chromium.org/11299008/diff/8007/chrome/browser/sync_file_sy...
chrome/browser/sync_file_system/remote_file_sync_service.h:62: 
On 2012/11/16 05:21:51, tzik wrote:
> Could you add getters for state and description?

Per offline chat I didn't add them for now. (Let's revisit when they're needed)

[tzik, 2012-11-16 06:04:46]

lgtm

LGTM again.