Issue 1129893004: Avoid clobbering generated files if the content hasn't changed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1129893004: Avoid clobbering generated files if the content hasn't changed. (Closed)

Created:
5 years, 7 months ago by Peter Lundblad

Modified:
5 years, 7 months ago

Reviewers:
dmazzoni

CC:
chromium-reviews, dtseng+watch_chromium.org, nkostylev+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Avoid clobbering generated files if the content hasn't changed. When editing javascript gtest files, the generated C++ file that runs the tests rarely changes. Not rewriting them avoids recompiles and relinks of the test binary which speeds up incremental builds. R=dmazzoni@chromium.org BUG= Committed: https://crrev.com/9e0db32de116c0e36f66ca2785485e412451fe24 Cr-Commit-Position: refs/heads/master@{#329187}

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -10 lines)			Patch
	M	chrome/browser/resources/chromeos/chromevox/tools/generate_deps.py	View		2 chunks	+19 lines, -7 lines	0 comments	Download
	M	tools/gypv8sh.py	View		3 chunks	+14 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129893004/1

5 years, 7 months ago (2015-05-11 17:09:33 UTC) #4

commit-bot: I haz the power

5 years, 7 months ago (2015-05-11 18:14:49 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/9e0db32de116c0e36f66ca2785485e412451fe24
Cr-Commit-Position: refs/heads/master@{#329187}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages