Issue 1129863008: Revert of Refactor GrBufferAllocPools to use resource cache

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1129863008: Revert of Refactor GrBufferAllocPools to use resource cache (Closed)

Created:
5 years, 7 months ago by robertphillips

Modified:
5 years, 7 months ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Refactor GrBufferAllocPools to use resource cache (patchset #9 id:160001 of https://codereview.chromium.org/1139753002/) Reason for revert: Perf Regression for some bot/skp combinations Original issue's description: > Refactor GrBufferAllocPools to use resource cache > > Committed: https://skia.googlesource.com/skia/+/c5f1c5414fc8f73cbefadcc1b24ec794056fa203 TBR=bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/eea2ff72014d985166e8c2aab3537bd32591900a

Created: 5 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+151 lines, -152 lines)			Patch
M	include/gpu/GrTextureProvider.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrBatchTarget.h	View	1 chunk	+8 lines, -8 lines	0 comments	Download
M	src/gpu/GrBatchTarget.cpp	View	2 chunks	+15 lines, -4 lines	0 comments	Download
M	src/gpu/GrBufferAllocPool.h	View	6 chunks	+29 lines, -9 lines	0 comments	Download
M	src/gpu/GrBufferAllocPool.cpp	View	14 chunks	+95 lines, -39 lines	0 comments	Download
M	src/gpu/GrIndexBuffer.h	View	2 chunks	+1 line, -16 lines	0 comments	Download
M	src/gpu/GrResourceProvider.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/gpu/GrResourceProvider.cpp	View	2 chunks	+1 line, -56 lines	0 comments	Download
M	src/gpu/GrVertexBuffer.h	View	1 chunk	+1 line, -16 lines	0 comments	Download

Total messages: 3 (0 generated)

robertphillips

Created Revert of Refactor GrBufferAllocPools to use resource cache

5 years, 7 months ago (2015-05-14 12:24:35 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129863008/1

5 years, 7 months ago (2015-05-14 12:24:42 UTC) #2

commit-bot: I haz the power

5 years, 7 months ago (2015-05-14 12:24:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/eea2ff72014d985166e8c2aab3537bd32591900a