Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 1129863007: look for deleted pts when detecting line/curve coincident edges (Closed)

Created:
5 years, 7 months ago by caryclark
Modified:
5 years, 7 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

look for deleted pts when detecting line/curve coincident edges TBR=reed@google.com BUG=skia:3651 Committed: https://skia.googlesource.com/skia/+/182b499cd75c971f85cdf52c1827b3c220cc9011

Patch Set 1 #

Patch Set 2 : fix path op builder #

Unified diffs Side-by-side diffs Delta from patch set Stats (+603 lines, -433 lines) Patch
M src/pathops/SkOpBuilder.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/pathops/SkOpCoincidence.cpp View 1 chunk +8 lines, -2 lines 0 comments Download
M src/pathops/SkOpSegment.cpp View 3 chunks +8 lines, -1 line 0 comments Download
M src/pathops/SkPathOpsDebug.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsBuilderTest.cpp View 1 1 chunk +26 lines, -0 lines 0 comments Download
M tests/PathOpsIssue3651.cpp View 1 chunk +187 lines, -0 lines 0 comments Download
M tests/PathOpsSimplifyTest.cpp View 1 1 chunk +24 lines, -0 lines 0 comments Download
M tools/pathops_visualizer.htm View 1 1 chunk +348 lines, -429 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129863007/1
5 years, 7 months ago (2015-05-14 12:21:58 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-14 12:28:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129863007/1
5 years, 7 months ago (2015-05-14 12:45:38 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 12:45:58 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/182b499cd75c971f85cdf52c1827b3c220cc9011

Powered by Google App Engine
This is Rietveld 408576698