src/full-codegen.cc - Issue 1129853002: Removing FLAG_vector_ics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen.cc

Issue 1129853002: Removing FLAG_vector_ics. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: REBASE. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen.cc

diff --git a/src/full-codegen.cc b/src/full-codegen.cc

index 0dac7d2e0b0bcec68e53eb19192e54fb88793a4e..b1eae719247486b8fcda1e26d0b4f4bb7cbe7278 100644

--- a/src/full-codegen.cc

+++ b/src/full-codegen.cc

@@ -445,13 +445,7 @@ void FullCodeGenerator::CallLoadIC(ContextualMode contextual_mode,

void FullCodeGenerator::CallGlobalLoadIC(Handle<String> name) {

- if (masm()->serializer_enabled() || FLAG_vector_ics) {

- // Vector-ICs don't work with LoadGlobalIC.

- return CallLoadIC(CONTEXTUAL);

- }

- Handle<Code> ic = CodeFactory::LoadGlobalIC(

- isolate(), isolate()->global_object(), name).code();

- CallIC(ic, TypeFeedbackId::None());

+ return CallLoadIC(CONTEXTUAL);

}