Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: src/compiler/js-generic-lowering.cc

Issue 1129853002: Removing FLAG_vector_ics. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/code-factory.h" 5 #include "src/code-factory.h"
6 #include "src/code-stubs.h" 6 #include "src/code-stubs.h"
7 #include "src/compiler/common-operator.h" 7 #include "src/compiler/common-operator.h"
8 #include "src/compiler/js-generic-lowering.h" 8 #include "src/compiler/js-generic-lowering.h"
9 #include "src/compiler/js-graph.h" 9 #include "src/compiler/js-graph.h"
10 #include "src/compiler/machine-operator.h" 10 #include "src/compiler/machine-operator.h"
(...skipping 291 matching lines...) Expand 10 before | Expand all | Expand 10 after
302 302
303 void JSGenericLowering::LowerJSToObject(Node* node) { 303 void JSGenericLowering::LowerJSToObject(Node* node) {
304 ReplaceWithBuiltinCall(node, Builtins::TO_OBJECT, 1); 304 ReplaceWithBuiltinCall(node, Builtins::TO_OBJECT, 1);
305 } 305 }
306 306
307 307
308 void JSGenericLowering::LowerJSLoadProperty(Node* node) { 308 void JSGenericLowering::LowerJSLoadProperty(Node* node) {
309 const LoadPropertyParameters& p = LoadPropertyParametersOf(node->op()); 309 const LoadPropertyParameters& p = LoadPropertyParametersOf(node->op());
310 Callable callable = 310 Callable callable =
311 CodeFactory::KeyedLoadICInOptimizedCode(isolate(), UNINITIALIZED); 311 CodeFactory::KeyedLoadICInOptimizedCode(isolate(), UNINITIALIZED);
312 if (FLAG_vector_ics) { 312 node->InsertInput(zone(), 2, jsgraph()->SmiConstant(p.feedback().index()));
313 node->InsertInput(zone(), 2, jsgraph()->SmiConstant(p.feedback().index())); 313 node->InsertInput(zone(), 3, jsgraph()->HeapConstant(p.feedback().vector()));
314 node->InsertInput(zone(), 3,
315 jsgraph()->HeapConstant(p.feedback().vector()));
316 }
317 ReplaceWithStubCall(node, callable, CallDescriptor::kPatchableCallSite); 314 ReplaceWithStubCall(node, callable, CallDescriptor::kPatchableCallSite);
318 } 315 }
319 316
320 317
321 void JSGenericLowering::LowerJSLoadNamed(Node* node) { 318 void JSGenericLowering::LowerJSLoadNamed(Node* node) {
322 const LoadNamedParameters& p = LoadNamedParametersOf(node->op()); 319 const LoadNamedParameters& p = LoadNamedParametersOf(node->op());
323 Callable callable = 320 Callable callable =
324 p.load_ic() == NAMED 321 p.load_ic() == NAMED
325 ? CodeFactory::LoadICInOptimizedCode(isolate(), p.contextual_mode(), 322 ? CodeFactory::LoadICInOptimizedCode(isolate(), p.contextual_mode(),
326 UNINITIALIZED) 323 UNINITIALIZED)
327 : CodeFactory::KeyedLoadICInOptimizedCode(isolate(), UNINITIALIZED); 324 : CodeFactory::KeyedLoadICInOptimizedCode(isolate(), UNINITIALIZED);
328 node->InsertInput(zone(), 1, jsgraph()->HeapConstant(p.name())); 325 node->InsertInput(zone(), 1, jsgraph()->HeapConstant(p.name()));
329 if (FLAG_vector_ics) { 326 node->InsertInput(zone(), 2, jsgraph()->SmiConstant(p.feedback().index()));
330 node->InsertInput(zone(), 2, jsgraph()->SmiConstant(p.feedback().index())); 327 node->InsertInput(zone(), 3, jsgraph()->HeapConstant(p.feedback().vector()));
331 node->InsertInput(zone(), 3,
332 jsgraph()->HeapConstant(p.feedback().vector()));
333 }
334 ReplaceWithStubCall(node, callable, CallDescriptor::kPatchableCallSite); 328 ReplaceWithStubCall(node, callable, CallDescriptor::kPatchableCallSite);
335 } 329 }
336 330
337 331
338 void JSGenericLowering::LowerJSStoreProperty(Node* node) { 332 void JSGenericLowering::LowerJSStoreProperty(Node* node) {
339 LanguageMode language_mode = OpParameter<LanguageMode>(node); 333 LanguageMode language_mode = OpParameter<LanguageMode>(node);
340 Callable callable = CodeFactory::KeyedStoreICInOptimizedCode( 334 Callable callable = CodeFactory::KeyedStoreICInOptimizedCode(
341 isolate(), language_mode, UNINITIALIZED); 335 isolate(), language_mode, UNINITIALIZED);
342 ReplaceWithStubCall(node, callable, CallDescriptor::kPatchableCallSite); 336 ReplaceWithStubCall(node, callable, CallDescriptor::kPatchableCallSite);
343 } 337 }
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
575 } 569 }
576 570
577 571
578 MachineOperatorBuilder* JSGenericLowering::machine() const { 572 MachineOperatorBuilder* JSGenericLowering::machine() const {
579 return jsgraph()->machine(); 573 return jsgraph()->machine();
580 } 574 }
581 575
582 } // namespace compiler 576 } // namespace compiler
583 } // namespace internal 577 } // namespace internal
584 } // namespace v8 578 } // namespace v8
OLDNEW
« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | src/flag-definitions.h » ('j') | src/ic/arm64/ic-arm64.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698